Re: [PATCH] meson: move pixman detection to meson

2020-08-30 Thread Paolo Bonzini
Il dom 30 ago 2020, 15:31 Stefan Weil ha scritto: > Obviously the compiler flags which are required for pixman-1 > (-I/usr/include/pixman-1) are not passed to the compiler. > Yes, they must be added to the modules' sourcesets. I will fix this. A build without --enable-modules does not show thes

Re: [PATCH] meson: move pixman detection to meson

2020-08-30 Thread Stefan Weil
Am 26.08.20 um 09:02 schrieb Paolo Bonzini: > When pixman is not installed (or too old), but virglrenderer is available > and "configure" has been run with "--disable-system", the build currently > aborts when trying to compile vhost-user-gpu (since it requires pixman). > > Let's skip the build of

Re: [PATCH] meson: move pixman detection to meson

2020-08-27 Thread Thomas Huth
On 26/08/2020 09.02, Paolo Bonzini wrote: > When pixman is not installed (or too old), but virglrenderer is available > and "configure" has been run with "--disable-system", the build currently > aborts when trying to compile vhost-user-gpu (since it requires pixman). > > Let's skip the build of v

Re: [PATCH] meson: move pixman detection to meson

2020-08-27 Thread Paolo Bonzini
Il gio 27 ago 2020, 09:28 Thomas Huth ha scritto: > But I've tested the patch now, and it does not work: > > .../qemu/meson.build:117:3: ERROR: Unknown variable "have_system". > > Should the pixman test maybe be moved to a later spot in the file? It > currently shows up before the have_system var

Re: [PATCH] meson: move pixman detection to meson

2020-08-27 Thread Thomas Huth
On 27/08/2020 08.14, Paolo Bonzini wrote: > > > Il gio 27 ago 2020, 06:53 Thomas Huth > ha scritto: > > > -else > > -  error_exit "pixman >= 0.21.8 not present." \ > > -      "Please install the pixman devel package." > > -fi > > The "else" part now

Re: [PATCH] meson: move pixman detection to meson

2020-08-26 Thread Paolo Bonzini
Il gio 27 ago 2020, 06:53 Thomas Huth ha scritto: > > -else > > - error_exit "pixman >= 0.21.8 not present." \ > > - "Please install the pixman devel package." > > -fi > > The "else" part now got completely lost, didn't it? It's replaced by "required: have_system" in meson.build. We can a

Re: [PATCH] meson: move pixman detection to meson

2020-08-26 Thread Thomas Huth
On 26/08/2020 09.02, Paolo Bonzini wrote: > When pixman is not installed (or too old), but virglrenderer is available > and "configure" has been run with "--disable-system", the build currently > aborts when trying to compile vhost-user-gpu (since it requires pixman). > > Let's skip the build of v

[PATCH] meson: move pixman detection to meson

2020-08-26 Thread Paolo Bonzini
When pixman is not installed (or too old), but virglrenderer is available and "configure" has been run with "--disable-system", the build currently aborts when trying to compile vhost-user-gpu (since it requires pixman). Let's skip the build of vhost-user-gpu when pixman is not installed or too ol