Re: [PATCH] meson: add more version numbers to the summary

2023-03-31 Thread Richard Henderson
On 3/31/23 07:54, Richard Henderson wrote: On 3/30/23 03:46, Paolo Bonzini wrote: -    cc.find_library('gpg-error', required: true)]) +    cc.find_library('gpg-error', required: true)], +    version: gcrypt.version()) Indentation. Bah, mis-read the patch. Reviewed-by: Richard

Re: [PATCH] meson: add more version numbers to the summary

2023-03-31 Thread Richard Henderson
On 3/30/23 03:46, Paolo Bonzini wrote: -cc.find_library('gpg-error', required: true)]) +cc.find_library('gpg-error', required: true)], +version: gcrypt.version()) Indentation. Reviewed-by: Richard Henderson r~

Re: [PATCH] meson: add more version numbers to the summary

2023-03-30 Thread Philippe Mathieu-Daudé
On 30/3/23 12:46, Paolo Bonzini wrote: Whenever declare_dependency is used to add some compile flags or dependent libraries to the outcome of dependency(), the version of the original dependency is dropped in the summary. Make sure that declare_dependency() has a version argument in those cases.

[PATCH] meson: add more version numbers to the summary

2023-03-30 Thread Paolo Bonzini
Whenever declare_dependency is used to add some compile flags or dependent libraries to the outcome of dependency(), the version of the original dependency is dropped in the summary. Make sure that declare_dependency() has a version argument in those cases. Signed-off-by: Paolo Bonzini --- meso