Re: [PATCH] meson: Adjust check for __int128_t

2023-05-24 Thread Paolo Bonzini
On 5/24/23 14:33, Peter Maydell wrote: On Wed, 24 May 2023 at 13:32, Paolo Bonzini wrote: Queued, thanks. Can you unqueue it, please? This is reverting a fix we deliberately put in in commit 464e3671f9d5c. Yes, I have done so. Paolo

Re: [PATCH] meson: Adjust check for __int128_t

2023-05-24 Thread Paolo Bonzini
On 5/24/23 12:30, Peter Maydell wrote: On Tue, 23 May 2023 at 23:39, Richard Henderson wrote: Remove the signed * signed check, leaving the signed * unsigned check. This link test runs foul of -fsanitize=undefined, where clang-11 has an undefined reference to __muloti4 to check for signed over

Re: [PATCH] meson: Adjust check for __int128_t

2023-05-24 Thread Peter Maydell
On Wed, 24 May 2023 at 13:32, Paolo Bonzini wrote: > > Queued, thanks. Can you unqueue it, please? This is reverting a fix we deliberately put in in commit 464e3671f9d5c. thanks -- PMM

Re: [PATCH] meson: Adjust check for __int128_t

2023-05-24 Thread Paolo Bonzini
Queued, thanks. Paolo

Re: [PATCH] meson: Adjust check for __int128_t

2023-05-24 Thread Peter Maydell
On Tue, 23 May 2023 at 23:39, Richard Henderson wrote: > > Remove the signed * signed check, leaving the signed * unsigned check. > This link test runs foul of -fsanitize=undefined, where clang-11 has > an undefined reference to __muloti4 to check for signed overflow. If you can't do a signed * s

[PATCH] meson: Adjust check for __int128_t

2023-05-23 Thread Richard Henderson
Remove the signed * signed check, leaving the signed * unsigned check. This link test runs foul of -fsanitize=undefined, where clang-11 has an undefined reference to __muloti4 to check for signed overflow. This failure prevents us properly detecting atomic128 support. Signed-off-by: Richard Hende