Re: [PATCH] log: make '-msg timestamp=on' apply to all qemu_log usage

2025-07-22 Thread Vladimir Sementsov-Ogievskiy
On 21.07.25 21:54, Daniel P. Berrangé wrote: Currently the tracing 'log' back emits special code to add timestamps to trace points sent via qemu_log(). This current impl is a bad design for a number of reasons. * It changes the QEMU headers, such that 'error-report.h' content is visible to

Re: [PATCH] log: make '-msg timestamp=on' apply to all qemu_log usage

2025-07-22 Thread Vladimir Sementsov-Ogievskiy
On 21.07.25 23:22, Stefan Hajnoczi wrote: On Mon, Jul 21, 2025 at 2:58 PM Daniel P. Berrangé wrote: Currently the tracing 'log' back emits special code to add timestamps to trace points sent via qemu_log(). This current impl is a bad design for a number of reasons. * It changes the QEMU hea

Re: [PATCH] log: make '-msg timestamp=on' apply to all qemu_log usage

2025-07-22 Thread Markus Armbruster
Daniel P. Berrangé writes: > Currently the tracing 'log' back emits special code to add timestamps > to trace points sent via qemu_log(). This current impl is a bad design > for a number of reasons. > > * It changes the QEMU headers, such that 'error-report.h' content >is visible to all file

Re: [PATCH] log: make '-msg timestamp=on' apply to all qemu_log usage

2025-07-21 Thread Stefan Hajnoczi
On Mon, Jul 21, 2025 at 2:58 PM Daniel P. Berrangé wrote: > > Currently the tracing 'log' back emits special code to add timestamps > to trace points sent via qemu_log(). This current impl is a bad design > for a number of reasons. > > * It changes the QEMU headers, such that 'error-report.h' con

[PATCH] log: make '-msg timestamp=on' apply to all qemu_log usage

2025-07-21 Thread Daniel P . Berrangé
Currently the tracing 'log' back emits special code to add timestamps to trace points sent via qemu_log(). This current impl is a bad design for a number of reasons. * It changes the QEMU headers, such that 'error-report.h' content is visible to all files using tracing, but only when the 'log'