Re: [PATCH] linux-aio: add IO_CMD_FDSYNC command support

2024-03-10 Thread Prasad Pandit
Hello Kevin, On Fri, 8 Mar 2024 at 17:38, Prasad Pandit wrote: > I'm trying to test it against the Fedora-26 kernel, which was < 4.13.0, and > did not support the AIO_FDSYNC call. [PATCH v2] -> https://lists.nongnu.org/archive/html/qemu-devel/2024-03/msg02495.html * I've sent v2 of this patch

Re: [PATCH] linux-aio: add IO_CMD_FDSYNC command support

2024-03-08 Thread Prasad Pandit
Hello Kevin, On Fri, 8 Mar 2024 at 14:35, Kevin Wolf wrote: > Hm... This might make it more challenging because then not only one > specific request fails, but the whole submission batch. * Yes exactly. * I've updated yesterday's patch to return an error (-EINVAL) from ioq_submit to laio_co_subm

Re: [PATCH] linux-aio: add IO_CMD_FDSYNC command support

2024-03-08 Thread Kevin Wolf
Am 07.03.2024 um 18:19 hat Prasad Pandit geschrieben: > Hi, > > On Thu, 7 Mar 2024 at 19:21, Kevin Wolf wrote: > > Kernel support for this is "relatively" new, added in 2018. Should we > > fall back to the thread pool if we receive -EINVAL? > > laio_co_submit > laio_do_submit > ioq_submit

Re: [PATCH] linux-aio: add IO_CMD_FDSYNC command support

2024-03-07 Thread Prasad Pandit
Hi, On Thu, 7 Mar 2024 at 19:21, Kevin Wolf wrote: > Kernel support for this is "relatively" new, added in 2018. Should we > fall back to the thread pool if we receive -EINVAL? laio_co_submit laio_do_submit ioq_submit io_submit * When an aio operation is not supported by the kernel,

Re: [PATCH] linux-aio: add IO_CMD_FDSYNC command support

2024-03-07 Thread Kevin Wolf
Am 07.03.2024 um 12:47 hat Prasad Pandit geschrieben: > From: Prasad Pandit > > Libaio defines IO_CMD_FDSYNC command to sync all outstanding > asynchronous I/O operations, by flushing out file data to the > disk storage. > > Enable linux-aio to submit such aio request. This helps to > reduce lat

[PATCH] linux-aio: add IO_CMD_FDSYNC command support

2024-03-07 Thread Prasad Pandit
From: Prasad Pandit Libaio defines IO_CMD_FDSYNC command to sync all outstanding asynchronous I/O operations, by flushing out file data to the disk storage. Enable linux-aio to submit such aio request. This helps to reduce latency induced via pthread_create calls by thread-pool (aio=threads). S