Re: [PATCH] libqtest: check for g_setenv() failure

2021-09-01 Thread Thomas Huth
On 20/08/2021 18.37, Peter Maydell wrote: g_setenv() can fail; check for it when starting a QEMU process when we set the QEMU_AUDIO_DRV environment variable. Because this happens after fork() reporting an exact message via printf() is a bad idea; just exit(1), as we already do for the case of ex

Re: [PATCH] libqtest: check for g_setenv() failure

2021-08-20 Thread Philippe Mathieu-Daudé
On 8/20/21 6:37 PM, Peter Maydell wrote: > g_setenv() can fail; check for it when starting a QEMU process > when we set the QEMU_AUDIO_DRV environment variable. > > Because this happens after fork() reporting an exact message > via printf() is a bad idea; just exit(1), as we already do > for the c

[PATCH] libqtest: check for g_setenv() failure

2021-08-20 Thread Peter Maydell
g_setenv() can fail; check for it when starting a QEMU process when we set the QEMU_AUDIO_DRV environment variable. Because this happens after fork() reporting an exact message via printf() is a bad idea; just exit(1), as we already do for the case of execlp() failure. Fixes: Coverity CID 1460117