Re: [PATCH] libqos: usb-hcd-ehci: use 32-bit write for config register

2020-06-24 Thread Paolo Bonzini
On 24/06/20 09:47, Thomas Huth wrote: >> >>   { >>   /* hands over all ports from companion uhci to ehci */ >> -    qpci_io_writew(ehci1.dev, ehci1.bar, 0x60, 1); >> +    qpci_io_writel(ehci1.dev, ehci1.bar, 0x60, 1); >>   } >>     static void pci_uhci_port_2(void) > > Passes "make check-qtest

Re: [PATCH] libqos: usb-hcd-ehci: use 32-bit write for config register

2020-06-24 Thread Thomas Huth
On 23/06/2020 18.18, Paolo Bonzini wrote: The memory region ops have min_access_size == 4 so obey it. Signed-off-by: Paolo Bonzini --- tests/qtest/usb-hcd-ehci-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/usb-hcd-ehci-test.c b/tests/qtest/usb-hcd-ehc

Re: [PATCH] libqos: usb-hcd-ehci: use 32-bit write for config register

2020-06-23 Thread Paolo Bonzini
On 23/06/20 22:56, Michael S. Tsirkin wrote: > On Tue, Jun 23, 2020 at 12:18:52PM -0400, Paolo Bonzini wrote: >> The memory region ops have min_access_size == 4 so obey it. >> >> Signed-off-by: Paolo Bonzini > > Makes sense. > > Acked-by: Michael S. Tsirkin > > I assume you are queueing this w

Re: [PATCH] libqos: usb-hcd-ehci: use 32-bit write for config register

2020-06-23 Thread Michael S. Tsirkin
On Tue, Jun 23, 2020 at 12:18:52PM -0400, Paolo Bonzini wrote: > The memory region ops have min_access_size == 4 so obey it. > > Signed-off-by: Paolo Bonzini Makes sense. Acked-by: Michael S. Tsirkin I assume you are queueing this with the memory core change. > --- > tests/qtest/usb-hcd-ehc

[PATCH] libqos: usb-hcd-ehci: use 32-bit write for config register

2020-06-23 Thread Paolo Bonzini
The memory region ops have min_access_size == 4 so obey it. Signed-off-by: Paolo Bonzini --- tests/qtest/usb-hcd-ehci-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/usb-hcd-ehci-test.c b/tests/qtest/usb-hcd-ehci-test.c index 5251d539e9..c51e8bb223 100644 -