Re: [PATCH] iotests: fix copy-before-write for macOS and FreeBSD

2022-07-12 Thread Richard Henderson
On 7/5/22 21:07, Vladimir Sementsov-Ogievskiy wrote: strerror() represents ETIMEDOUT a bit different in Linux and macOS / FreeBSD. Let's support the latter too. Fixes: 9d05a87b77 ("iotests: copy-before-write: add cases for cbw-timeout option") Signed-off-by: Vladimir Sementsov-Ogievskiy --- A

Re: [PATCH] iotests: fix copy-before-write for macOS and FreeBSD

2022-07-06 Thread Hanna Reitz
On 06.07.22 16:46, Vladimir Sementsov-Ogievskiy wrote: On 7/6/22 13:26, Hanna Reitz wrote: On 05.07.22 17:37, Vladimir Sementsov-Ogievskiy wrote: strerror() represents ETIMEDOUT a bit different in Linux and macOS / FreeBSD. Let's support the latter too. Fixes: 9d05a87b77 ("iotests: copy-before

Re: [PATCH] iotests: fix copy-before-write for macOS and FreeBSD

2022-07-06 Thread Vladimir Sementsov-Ogievskiy
On 7/6/22 13:26, Hanna Reitz wrote: On 05.07.22 17:37, Vladimir Sementsov-Ogievskiy wrote: strerror() represents ETIMEDOUT a bit different in Linux and macOS / FreeBSD. Let's support the latter too. Fixes: 9d05a87b77 ("iotests: copy-before-write: add cases for cbw-timeout option") Signed-off-b

Re: [PATCH] iotests: fix copy-before-write for macOS and FreeBSD

2022-07-06 Thread Vladimir Sementsov-Ogievskiy
On 7/6/22 13:26, Hanna Reitz wrote: On 05.07.22 17:37, Vladimir Sementsov-Ogievskiy wrote: strerror() represents ETIMEDOUT a bit different in Linux and macOS / FreeBSD. Let's support the latter too. Fixes: 9d05a87b77 ("iotests: copy-before-write: add cases for cbw-timeout option") Signed-off-b

Re: [PATCH] iotests: fix copy-before-write for macOS and FreeBSD

2022-07-06 Thread Hanna Reitz
On 05.07.22 17:37, Vladimir Sementsov-Ogievskiy wrote: strerror() represents ETIMEDOUT a bit different in Linux and macOS / FreeBSD. Let's support the latter too. Fixes: 9d05a87b77 ("iotests: copy-before-write: add cases for cbw-timeout option") Signed-off-by: Vladimir Sementsov-Ogievskiy ---

Re: [PATCH] iotests: fix copy-before-write for macOS and FreeBSD

2022-07-06 Thread Peter Maydell
On Wed, 6 Jul 2022 at 08:39, Thomas Huth wrote: > Many of the iotests rely on output text matching. It's very fragile, always > has been and always will be (unless we rewrite the whole test suite to not > use output text matching anymore). Maybe you could have a pre-pass over the "expected result

Re: [PATCH] iotests: fix copy-before-write for macOS and FreeBSD

2022-07-06 Thread Thomas Huth
On 05/07/2022 19.22, Richard Henderson wrote: On 7/5/22 21:07, Vladimir Sementsov-Ogievskiy wrote: strerror() represents ETIMEDOUT a bit different in Linux and macOS / FreeBSD. Let's support the latter too. Fixes: 9d05a87b77 ("iotests: copy-before-write: add cases for cbw-timeout option") Sig

Re: [PATCH] iotests: fix copy-before-write for macOS and FreeBSD

2022-07-06 Thread Thomas Huth
On 05/07/2022 17.37, Vladimir Sementsov-Ogievskiy wrote: strerror() represents ETIMEDOUT a bit different in Linux and macOS / FreeBSD. Let's support the latter too. Fixes: 9d05a87b77 ("iotests: copy-before-write: add cases for cbw-timeout option") Signed-off-by: Vladimir Sementsov-Ogievskiy --

Re: [PATCH] iotests: fix copy-before-write for macOS and FreeBSD

2022-07-05 Thread Vladimir Sementsov-Ogievskiy
On 7/5/22 20:22, Richard Henderson wrote: On 7/5/22 21:07, Vladimir Sementsov-Ogievskiy wrote: strerror() represents ETIMEDOUT a bit different in Linux and macOS / FreeBSD. Let's support the latter too. Fixes: 9d05a87b77 ("iotests: copy-before-write: add cases for cbw-timeout option") Signed-o

Re: [PATCH] iotests: fix copy-before-write for macOS and FreeBSD

2022-07-05 Thread Richard Henderson
On 7/5/22 21:07, Vladimir Sementsov-Ogievskiy wrote: strerror() represents ETIMEDOUT a bit different in Linux and macOS / FreeBSD. Let's support the latter too. Fixes: 9d05a87b77 ("iotests: copy-before-write: add cases for cbw-timeout option") Signed-off-by: Vladimir Sementsov-Ogievskiy --- A

[PATCH] iotests: fix copy-before-write for macOS and FreeBSD

2022-07-05 Thread Vladimir Sementsov-Ogievskiy
strerror() represents ETIMEDOUT a bit different in Linux and macOS / FreeBSD. Let's support the latter too. Fixes: 9d05a87b77 ("iotests: copy-before-write: add cases for cbw-timeout option") Signed-off-by: Vladimir Sementsov-Ogievskiy --- As John and Thomas noted, the new iotests fails for Free