Re: [PATCH] io/channel-websock: treat 'binary' and no sub-protocol as the same

2020-02-06 Thread Yu-Chen Lin
Since there are no changes in two months. Simply ping for merging, sorry for bothering you again. Daniel P. Berrangé 於 2019年12月2日 週一 下午11:53寫道: > On Sat, Nov 23, 2019 at 11:43:06AM +0800, Yu-Chen Lin wrote: > > noVNC doesn't use 'binary' protocol by default after > > commit c912230309806aacbae42

Re: [PATCH] io/channel-websock: treat 'binary' and no sub-protocol as the same

2019-12-02 Thread Daniel P . Berrangé
On Sat, Nov 23, 2019 at 11:43:06AM +0800, Yu-Chen Lin wrote: > noVNC doesn't use 'binary' protocol by default after > commit c912230309806aacbae4295faf7ad6406da97617. > > It will cause qemu return 400 when handshaking. > > To overcome this problem and remain compatibility of > older noVNC client.

Re: [PATCH] io/channel-websock: treat 'binary' and no sub-protocol as the same

2019-11-28 Thread Yu-Chen Lin
Ping? Yu-Chen Lin 於 2019年11月23日 週六 11:43 寫道: > noVNC doesn't use 'binary' protocol by default after > commit c912230309806aacbae4295faf7ad6406da97617. > > It will cause qemu return 400 when handshaking. > > To overcome this problem and remain compatibility of > older noVNC client. > > We treat '

[PATCH] io/channel-websock: treat 'binary' and no sub-protocol as the same

2019-11-22 Thread Yu-Chen Lin
noVNC doesn't use 'binary' protocol by default after commit c912230309806aacbae4295faf7ad6406da97617. It will cause qemu return 400 when handshaking. To overcome this problem and remain compatibility of older noVNC client. We treat 'binary' and no sub-protocol as the same so that we can support