Re: [PATCH] intel_iommu: Allow both Status Write and Interrupt Flag in QI wait

2025-07-14 Thread David Woodhouse
On Sun, 2025-07-13 at 17:29 -0400, Michael S. Tsirkin wrote: > > > +    if (inv_desc->lo & VTD_INV_DESC_WAIT_IF) > > +    vtd_generate_completion_event(s); > >   > >   /* FIXME: need to be masked with HAW? */ > >   dma_addr_t status_addr = inv_desc->hi; > > Follow QEM

Re: [PATCH] intel_iommu: Allow both Status Write and Interrupt Flag in QI wait

2025-07-13 Thread Michael S. Tsirkin
On Fri, Jul 11, 2025 at 10:47:47AM +0100, David Woodhouse wrote: > From: David Woodhouse > > FreeBSD does both, and this appears to be perfectly valid. The VT-d > spec even talks about the ordering (the status write should be done > first, unsurprisingly). > > We certainly shouldn't assert() and

[PATCH] intel_iommu: Allow both Status Write and Interrupt Flag in QI wait

2025-07-11 Thread David Woodhouse
From: David Woodhouse FreeBSD does both, and this appears to be perfectly valid. The VT-d spec even talks about the ordering (the status write should be done first, unsurprisingly). We certainly shouldn't assert() and abort QEMU if the guest asks for both. Fixes: ed7b8fbcfb88 ("intel-iommu: add