Re: [PATCH] inet_parse: Clarify IPv6 comment and error message

2021-03-08 Thread Eric Blake
On 3/8/21 5:30 AM, Daniel P. Berrangé wrote: > On Sun, Mar 07, 2021 at 05:31:24PM -0800, Doug Evans wrote: >> Not sure how this "Author email address is mangled" happened. >> >> $ git format-patch -o patches/error-parsing-ipv6 -1 >> $ git send-email --to='qemu-devel@nongnu.org,Samuel Thibault < >>

Re: [PATCH] inet_parse: Clarify IPv6 comment and error message

2021-03-08 Thread Daniel P . Berrangé
On Sun, Mar 07, 2021 at 04:29:28PM -0800, Doug Evans via wrote: > Wrapping an IP address in square brackets does not necessarily > mean the address is an IPv6 address. The wrapping is just an aid > to parsing since IPv6 addresses have colons, but does not provide > semantic information. > E.g., [12

Re: [PATCH] inet_parse: Clarify IPv6 comment and error message

2021-03-08 Thread Daniel P . Berrangé
On Sun, Mar 07, 2021 at 05:31:24PM -0800, Doug Evans wrote: > Not sure how this "Author email address is mangled" happened. > > $ git format-patch -o patches/error-parsing-ipv6 -1 > $ git send-email --to='qemu-devel@nongnu.org,Samuel Thibault < > samuel.thiba...@ens-lyon.org>,"Daniel P. Berrangé"

Re: [PATCH] inet_parse: Clarify IPv6 comment and error message

2021-03-07 Thread Doug Evans
te: > Patchew URL: > https://patchew.org/QEMU/20210308002928.3385275-1-...@google.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Type: series > Message-id: 20210308002928.3385275-1-...@google.com

Re: [PATCH] inet_parse: Clarify IPv6 comment and error message

2021-03-07 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20210308002928.3385275-1-...@google.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210308002928.3385275-1-...@google.com Subject: [PATCH] inet_parse: Clarify IPv6 comment

[PATCH] inet_parse: Clarify IPv6 comment and error message

2021-03-07 Thread Doug Evans via
Wrapping an IP address in square brackets does not necessarily mean the address is an IPv6 address. The wrapping is just an aid to parsing since IPv6 addresses have colons, but does not provide semantic information. E.g., [127.0.0.1] is a valid way to write 127.0.0.1. Signed-off-by: Doug Evans --