Re: [PATCH] i386/xen: fix off-by-one in xen_evtchn_set_gsi()

2023-07-17 Thread Peter Maydell
On Tue, 4 Jul 2023 at 16:13, Woodhouse, David wrote: > > Coverity points out (CID 1508128) a bounds checking error. We need to check > for gsi >= IOAPIC_NUM_PINS, not just greater-than. > > Also fix up an assert() that has the same problem, that Coverity didn't see. > > Signed-off-by: David Woodho

[PATCH] i386/xen: fix off-by-one in xen_evtchn_set_gsi()

2023-07-04 Thread Woodhouse, David
Coverity points out (CID 1508128) a bounds checking error. We need to check for gsi >= IOAPIC_NUM_PINS, not just greater-than. Also fix up an assert() that has the same problem, that Coverity didn't see. Signed-off-by: David Woodhouse --- hw/i386/kvm/xen_evtchn.c | 4 ++-- 1 file changed, 2 ins