Re: [PATCH] hw: Do not include hw/sysbus.h if it is not necessary

2021-04-30 Thread Laurent Vivier
Le 27/03/2021 à 09:28, Thomas Huth a écrit : > Many files include hw/sysbus.h without needing it. Remove the superfluous > include statements. > > Signed-off-by: Thomas Huth > --- > hw/arm/cubieboard.c | 1 - > hw/arm/orangepi.c | 1 - > hw/char/riscv_htif.c| 1 - > hw/

Re: [PATCH] hw: Do not include hw/sysbus.h if it is not necessary

2021-03-27 Thread Philippe Mathieu-Daudé
On 3/27/21 7:35 PM, Philippe Mathieu-Daudé wrote: > On 3/27/21 7:19 PM, Thomas Huth wrote: >> On 27/03/2021 15.54, Philippe Mathieu-Daudé wrote: >>> Hi Thomas, >>> >>> 6 more candidates? >> >> No, since those use TYPE_SYS_BUS_DEVICE and thus require hw/sysbus.h. > > Ah indeed, this line matches y

Re: [PATCH] hw: Do not include hw/sysbus.h if it is not necessary

2021-03-27 Thread Philippe Mathieu-Daudé
On 3/27/21 7:19 PM, Thomas Huth wrote: > On 27/03/2021 15.54, Philippe Mathieu-Daudé wrote: >> Hi Thomas, >> >> On 3/27/21 9:28 AM, Thomas Huth wrote: >>> Many files include hw/sysbus.h without needing it. Remove the >>> superfluous >>> include statements. >>> >>> Signed-off-by: Thomas Huth >>>

Re: [PATCH] hw: Do not include hw/sysbus.h if it is not necessary

2021-03-27 Thread Thomas Huth
On 27/03/2021 15.54, Philippe Mathieu-Daudé wrote: Hi Thomas, On 3/27/21 9:28 AM, Thomas Huth wrote: Many files include hw/sysbus.h without needing it. Remove the superfluous include statements. Signed-off-by: Thomas Huth --- hw/arm/cubieboard.c | 1 - hw/arm/orangepi.c |

Re: [PATCH] hw: Do not include hw/sysbus.h if it is not necessary

2021-03-27 Thread Philippe Mathieu-Daudé
Hi Thomas, On 3/27/21 9:28 AM, Thomas Huth wrote: > Many files include hw/sysbus.h without needing it. Remove the superfluous > include statements. > > Signed-off-by: Thomas Huth > --- > hw/arm/cubieboard.c | 1 - > hw/arm/orangepi.c | 1 - > hw/char/riscv_htif.c| 1 -

[PATCH] hw: Do not include hw/sysbus.h if it is not necessary

2021-03-27 Thread Thomas Huth
Many files include hw/sysbus.h without needing it. Remove the superfluous include statements. Signed-off-by: Thomas Huth --- hw/arm/cubieboard.c | 1 - hw/arm/orangepi.c | 1 - hw/char/riscv_htif.c| 1 - hw/char/sifive_uart.c | 1 - hw/char/virtio-serial-bus.c | 1