Re: [PATCH] hw/xen: Fix trace_xs_node_read() params

2025-05-27 Thread Richard Henderson
On 5/26/25 19:10, Philippe Mathieu-Daudé wrote: Alternatively, since this is an error path: -- >8 -- diff --git a/hw/xen/xen-bus-helper.c b/hw/xen/xen-bus-helper.c index 288fad422be..1e49e60e147 100644 --- a/hw/xen/xen-bus-helper.c +++ b/hw/xen/xen-bus-helper.c @@ -143,7 +143,8 @@ char *xs_node_

Re: [PATCH] hw/xen: Fix trace_xs_node_read() params

2025-05-26 Thread Philippe Mathieu-Daudé
On 23/5/25 18:01, Liam Merwick wrote: When the '--enable-trace-backends=syslog' build option is configured, the following compilation error is encountered. In file included from /usr/include/sys/syslog.h:207, from /usr/include/syslog.h:1, from ./trace/trace-hw

Re: [PATCH] hw/xen: Fix trace_xs_node_read() params

2025-05-26 Thread Anthony PERARD
On Fri, May 23, 2025 at 04:01:34PM +, Liam Merwick wrote: > When the '--enable-trace-backends=syslog' build option is configured, > the following compilation error is encountered. > > In file included from /usr/include/sys/syslog.h:207, > from /usr/include/syslog.h:1, >

Re: [EXTERNAL] [PATCH] hw/xen: Fix trace_xs_node_read() params

2025-05-23 Thread David Woodhouse
On Fri, 2025-05-23 at 16:01 +, Liam Merwick wrote: > When the '--enable-trace-backends=syslog' build option is configured, > the following compilation error is encountered. > > In file included from /usr/include/sys/syslog.h:207, > from /usr/include/syslog.h:1, >  

[PATCH] hw/xen: Fix trace_xs_node_read() params

2025-05-23 Thread Liam Merwick
When the '--enable-trace-backends=syslog' build option is configured, the following compilation error is encountered. In file included from /usr/include/sys/syslog.h:207, from /usr/include/syslog.h:1, from ./trace/trace-hw_xen.h:224, from ../hw/xe