Re: [PATCH] hw/virtio: Update vring after modifying its queue size

2021-09-14 Thread Alexander Bulekov
On 210826 0042, Philippe Mathieu-Daudé wrote: > When a ring queue size is modified, we need to call > virtio_queue_update_rings() to re-init the memory region > caches. Otherwise the region might have outdated memory > size, and later load/store access might trigger an > assertion, such: > > qem

Re: [PATCH] hw/virtio: Update vring after modifying its queue size

2021-09-02 Thread Stefan Hajnoczi
On Thu, Aug 26, 2021 at 12:42:56AM +0200, Philippe Mathieu-Daudé wrote: > When a ring queue size is modified, we need to call > virtio_queue_update_rings() to re-init the memory region > caches. Otherwise the region might have outdated memory > size, and later load/store access might trigger an > a

Re: [PATCH] hw/virtio: Update vring after modifying its queue size

2021-08-30 Thread Michael S. Tsirkin
On Thu, Aug 26, 2021 at 10:40:47AM +0200, Philippe Mathieu-Daudé wrote: > On 8/26/21 5:28 AM, Jason Wang wrote: > > On Thu, Aug 26, 2021 at 6:43 AM Philippe Mathieu-Daudé > > wrote: > >> > >> When a ring queue size is modified, we need to call > >> virtio_queue_update_rings() to re-init the memory

Re: [PATCH] hw/virtio: Update vring after modifying its queue size

2021-08-30 Thread Michael S. Tsirkin
On Thu, Aug 26, 2021 at 05:16:03PM +0200, Philippe Mathieu-Daudé wrote: > On 8/26/21 10:40 AM, Philippe Mathieu-Daudé wrote: > > On 8/26/21 5:28 AM, Jason Wang wrote: > >> On Thu, Aug 26, 2021 at 6:43 AM Philippe Mathieu-Daudé > >> wrote: > >>> > >>> When a ring queue size is modified, we need to

Re: [PATCH] hw/virtio: Update vring after modifying its queue size

2021-08-26 Thread Philippe Mathieu-Daudé
On 8/26/21 10:40 AM, Philippe Mathieu-Daudé wrote: > On 8/26/21 5:28 AM, Jason Wang wrote: >> On Thu, Aug 26, 2021 at 6:43 AM Philippe Mathieu-Daudé >> wrote: >>> >>> When a ring queue size is modified, we need to call >>> virtio_queue_update_rings() to re-init the memory region >>> caches. Otherw

Re: [PATCH] hw/virtio: Update vring after modifying its queue size

2021-08-26 Thread Philippe Mathieu-Daudé
On 8/26/21 5:28 AM, Jason Wang wrote: > On Thu, Aug 26, 2021 at 6:43 AM Philippe Mathieu-Daudé > wrote: >> >> When a ring queue size is modified, we need to call >> virtio_queue_update_rings() to re-init the memory region >> caches. Otherwise the region might have outdated memory >> size, and late

Re: [PATCH] hw/virtio: Update vring after modifying its queue size

2021-08-25 Thread Jason Wang
On Thu, Aug 26, 2021 at 6:43 AM Philippe Mathieu-Daudé wrote: > > When a ring queue size is modified, we need to call > virtio_queue_update_rings() to re-init the memory region > caches. Otherwise the region might have outdated memory > size, and later load/store access might trigger an > assertio

Re: [PATCH] hw/virtio: Update vring after modifying its queue size

2021-08-25 Thread Philippe Mathieu-Daudé
On 8/26/21 12:42 AM, Philippe Mathieu-Daudé wrote: > When a ring queue size is modified, we need to call > virtio_queue_update_rings() to re-init the memory region > caches. Otherwise the region might have outdated memory > size, and later load/store access might trigger an > assertion, such: > >

[PATCH] hw/virtio: Update vring after modifying its queue size

2021-08-25 Thread Philippe Mathieu-Daudé
When a ring queue size is modified, we need to call virtio_queue_update_rings() to re-init the memory region caches. Otherwise the region might have outdated memory size, and later load/store access might trigger an assertion, such: qemu-system-i386: include/exec/memory_ldst_cached.h.inc:30: uin