Re: [PATCH] hw/vhost-user-blk: fix ioeventfd add failed when start reenter

2022-03-31 Thread Raphael Norwitz
High level looks good but I have some questions. Rather than a new boolean I'd rather we re-used started_vu by changing it to an enum and having different values for starting and started. On Tue, Mar 29, 2022 at 12:15:46AM +0800, Jie Wang wrote: > During Virtio1.0 dev(start_on_kick) in vhost_user

[PATCH] hw/vhost-user-blk: fix ioeventfd add failed when start reenter

2022-03-28 Thread Jie Wang via
During Virtio1.0 dev(start_on_kick) in vhost_user_blk_start process, if spdk abnormal after vhost_dev_enable_notifiers, then vhost_user_blk_start will goto vhost_dev_disable_notifiers and reenter vhost_user_blk_start, and add ioeventfd again. func call Process as follows: vhost_user_blk_start(spd