Re: [PATCH] hw/sd: print bad s->arglen in unexpected response

2025-07-24 Thread Ben Dooks
On 23/07/2025 17:30, Philippe Mathieu-Daudé wrote: Hi Ben, On 23/7/25 16:55, Ben Dooks wrote: I am currently trying to track down two errors with mmc-spi. The first looks like u-boot is sending a couple of CMDs (9, 10) in the wrong state (currently this works however with a real SD card) so I

Re: [PATCH] hw/sd: print bad s->arglen in unexpected response

2025-07-24 Thread Ben Dooks
On 23/07/2025 17:30, Philippe Mathieu-Daudé wrote: Hi Ben, On 23/7/25 16:55, Ben Dooks wrote: I am currently trying to track down two errors with mmc-spi. The first looks like u-boot is sending a couple of CMDs (9, 10) in the wrong state (currently this works however with a real SD card) so I

Re: [PATCH] hw/sd: print bad s->arglen in unexpected response

2025-07-23 Thread Philippe Mathieu-Daudé
Hi Ben, On 23/7/25 16:55, Ben Dooks wrote: I am currently trying to track down two errors with mmc-spi. The first looks like u-boot is sending a couple of CMDs (9, 10) in the wrong state (currently this works however with a real SD card) so I have a tmp-fix in to just ignore the two checks in

Re: [PATCH] hw/sd: print bad s->arglen in unexpected response

2025-07-23 Thread Ben Dooks
On 23/07/2025 14:38, Peter Maydell wrote: On Wed, 23 Jul 2025 at 13:47, Alex Bennée wrote: Ben Dooks writes: (Add maintainers to CC) You should get your patch workflow to use scripts/get_maintainer.pl so they get CC'd and reduces the chance of it being missed in the fire-hose of qemu-devel.

Re: [PATCH] hw/sd: print bad s->arglen in unexpected response

2025-07-23 Thread Peter Maydell
On Wed, 23 Jul 2025 at 13:47, Alex Bennée wrote: > > Ben Dooks writes: > > (Add maintainers to CC) > > You should get your patch workflow to use scripts/get_maintainer.pl so > they get CC'd and reduces the chance of it being missed in the fire-hose > of qemu-devel. > > > If we get "ssi_sd: error:

Re: [PATCH] hw/sd: print bad s->arglen in unexpected response

2025-07-23 Thread Alex Bennée
Ben Dooks writes: (Add maintainers to CC) You should get your patch workflow to use scripts/get_maintainer.pl so they get CC'd and reduces the chance of it being missed in the fire-hose of qemu-devel. > If we get "ssi_sd: error: Unexpected response to cmd" then having > the bad s->arglen would

[PATCH] hw/sd: print bad s->arglen in unexpected response

2025-07-22 Thread Ben Dooks
If we get "ssi_sd: error: Unexpected response to cmd" then having the bad s->arglen would be useful debug and does not add any complexity to the code. Signed-off-by: Ben Dooks --- hw/sd/ssi-sd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/sd/ssi-sd.c b/hw/sd/ssi-sd.c i