Re: [PATCH] hw/riscv: virt: Remove size restriction for pflash

2022-11-07 Thread Sunil V L
On Mon, Nov 07, 2022 at 05:57:45PM +0800, maobibo wrote: > > > 在 2022/11/6 22:39, Sunil V L 写道: > > The pflash implementation currently assumes fixed size of the > > backend storage. Due to this, the backend storage file needs to be > > exactly of size 32M. Otherwise, there will be an error like

Re: [PATCH] hw/riscv: virt: Remove size restriction for pflash

2022-11-07 Thread maobibo
在 2022/11/6 22:39, Sunil V L 写道: > The pflash implementation currently assumes fixed size of the > backend storage. Due to this, the backend storage file needs to be > exactly of size 32M. Otherwise, there will be an error like below. > > "device requires 33554432 bytes, block backend provides

Re: [PATCH] hw/riscv: virt: Remove size restriction for pflash

2022-11-07 Thread Sunil V L
On Mon, Nov 07, 2022 at 09:48:03AM +0100, Andrew Jones wrote: > On Mon, Nov 07, 2022 at 11:16:00AM +0530, Sunil V L wrote: > > On Sun, Nov 06, 2022 at 10:20:57PM +0300, Mike Maslenkin wrote: > > > Hello Sunil! > > > > > > What about virt_machine_done() function? > > > kernel_entry variable still p

Re: [PATCH] hw/riscv: virt: Remove size restriction for pflash

2022-11-07 Thread Andrew Jones
On Mon, Nov 07, 2022 at 11:16:00AM +0530, Sunil V L wrote: > On Sun, Nov 06, 2022 at 10:20:57PM +0300, Mike Maslenkin wrote: > > Hello Sunil! > > > > What about virt_machine_done() function? > > kernel_entry variable still points to the second flash started from > > virt_memmap[VIRT_FLASH].size /

Re: [PATCH] hw/riscv: virt: Remove size restriction for pflash

2022-11-06 Thread Sunil V L
On Sun, Nov 06, 2022 at 10:20:57PM +0300, Mike Maslenkin wrote: > Hello Sunil! > > What about virt_machine_done() function? > kernel_entry variable still points to the second flash started from > virt_memmap[VIRT_FLASH].size / 2. > The base address of the flash has not changed to keep things fle

Re: [PATCH] hw/riscv: virt: Remove size restriction for pflash

2022-11-06 Thread Mike Maslenkin
Hello Sunil! What about virt_machine_done() function? kernel_entry variable still points to the second flash started from virt_memmap[VIRT_FLASH].size / 2. On Sun, Nov 6, 2022 at 5:41 PM Sunil V L wrote: > > The pflash implementation currently assumes fixed size of the > backend storage. Due to

Re: [PATCH] hw/riscv: virt: Remove size restriction for pflash

2022-11-06 Thread Andrew Jones
On Sun, Nov 06, 2022 at 08:09:00PM +0530, Sunil V L wrote: > The pflash implementation currently assumes fixed size of the > backend storage. Due to this, the backend storage file needs to be > exactly of size 32M. Otherwise, there will be an error like below. > > "device requires 33554432 bytes,

[PATCH] hw/riscv: virt: Remove size restriction for pflash

2022-11-06 Thread Sunil V L
The pflash implementation currently assumes fixed size of the backend storage. Due to this, the backend storage file needs to be exactly of size 32M. Otherwise, there will be an error like below. "device requires 33554432 bytes, block backend provides 3145728 bytes" Fix this issue by using the ac