Re: [PATCH] hw/riscv: fix build error with clang

2024-11-04 Thread Pierrick Bouvier
On 11/1/24 10:08, Pierrick Bouvier wrote: Introduced in 0c54ac, "hw/riscv: add RISC-V IOMMU base emulation" ../hw/riscv/riscv-iommu.c:187:17: error: redefinition of '_pext_u64' 187 | static uint64_t _pext_u64(uint64_t val, uint64_t ext) | ^ D:/a/_temp/msys64/clang64/

Re: [PATCH] hw/riscv: fix build error with clang

2024-11-02 Thread Peter Maydell
On Fri, 1 Nov 2024 at 20:46, Daniel Henrique Barboza wrote: > Pierrick, I copied the description of this function from the riscv-isa spec > and put in a comment. This is how it would look like: > > $ git diff > diff --git a/hw/riscv/riscv-iommu.c b/hw/riscv/riscv-iommu.c > index feb650549a..969eb5

Re: [PATCH] hw/riscv: fix build error with clang

2024-11-01 Thread Pierrick Bouvier
On 11/1/24 13:46, Daniel Henrique Barboza wrote: On 11/1/24 4:23 PM, Tomasz Jeznach wrote: On Fri, Nov 1, 2024 at 11:49 AM Peter Maydell wrote: On Fri, 1 Nov 2024 at 18:13, Daniel Henrique Barboza wrote: (Ccing Tomasz) On 11/1/24 2:48 PM, Peter Maydell wrote: On Fri, 1 Nov 2024 at 17:3

Re: [PATCH] hw/riscv: fix build error with clang

2024-11-01 Thread Daniel Henrique Barboza
On 11/1/24 4:23 PM, Tomasz Jeznach wrote: On Fri, Nov 1, 2024 at 11:49 AM Peter Maydell wrote: On Fri, 1 Nov 2024 at 18:13, Daniel Henrique Barboza wrote: (Ccing Tomasz) On 11/1/24 2:48 PM, Peter Maydell wrote: On Fri, 1 Nov 2024 at 17:36, Daniel Henrique Barboza wrote: On 11/1/24

Re: [PATCH] hw/riscv: fix build error with clang

2024-11-01 Thread Tomasz Jeznach
On Fri, Nov 1, 2024 at 11:49 AM Peter Maydell wrote: > > On Fri, 1 Nov 2024 at 18:13, Daniel Henrique Barboza > wrote: > > > > (Ccing Tomasz) > > > > On 11/1/24 2:48 PM, Peter Maydell wrote: > > > On Fri, 1 Nov 2024 at 17:36, Daniel Henrique Barboza > > > wrote: > > >> > > >> > > >> > > >> On 11

Re: [PATCH] hw/riscv: fix build error with clang

2024-11-01 Thread Peter Maydell
On Fri, 1 Nov 2024 at 18:13, Daniel Henrique Barboza wrote: > > (Ccing Tomasz) > > On 11/1/24 2:48 PM, Peter Maydell wrote: > > On Fri, 1 Nov 2024 at 17:36, Daniel Henrique Barboza > > wrote: > >> > >> > >> > >> On 11/1/24 2:08 PM, Pierrick Bouvier wrote: > >>> Introduced in 0c54ac, "hw/riscv: ad

Re: [PATCH] hw/riscv: fix build error with clang

2024-11-01 Thread Daniel Henrique Barboza
(Ccing Tomasz) On 11/1/24 2:48 PM, Peter Maydell wrote: On Fri, 1 Nov 2024 at 17:36, Daniel Henrique Barboza wrote: On 11/1/24 2:08 PM, Pierrick Bouvier wrote: Introduced in 0c54ac, "hw/riscv: add RISC-V IOMMU base emulation" ../hw/riscv/riscv-iommu.c:187:17: error: redefinition of '_pext

Re: [PATCH] hw/riscv: fix build error with clang

2024-11-01 Thread Pierrick Bouvier
On 11/1/24 10:35, Daniel Henrique Barboza wrote: On 11/1/24 2:08 PM, Pierrick Bouvier wrote: Introduced in 0c54ac, "hw/riscv: add RISC-V IOMMU base emulation" ../hw/riscv/riscv-iommu.c:187:17: error: redefinition of '_pext_u64' 187 | static uint64_t _pext_u64(uint64_t val, uint64_t ext)

Re: [PATCH] hw/riscv: fix build error with clang

2024-11-01 Thread Pierrick Bouvier
On 11/1/24 10:48, Peter Maydell wrote: On Fri, 1 Nov 2024 at 17:36, Daniel Henrique Barboza wrote: On 11/1/24 2:08 PM, Pierrick Bouvier wrote: Introduced in 0c54ac, "hw/riscv: add RISC-V IOMMU base emulation" ../hw/riscv/riscv-iommu.c:187:17: error: redefinition of '_pext_u64' 187 | s

Re: [PATCH] hw/riscv: fix build error with clang

2024-11-01 Thread Peter Maydell
On Fri, 1 Nov 2024 at 17:36, Daniel Henrique Barboza wrote: > > > > On 11/1/24 2:08 PM, Pierrick Bouvier wrote: > > Introduced in 0c54ac, "hw/riscv: add RISC-V IOMMU base emulation" > > > > ../hw/riscv/riscv-iommu.c:187:17: error: redefinition of '_pext_u64' > > > >187 | static uint64_t _pext_

Re: [PATCH] hw/riscv: fix build error with clang

2024-11-01 Thread Daniel Henrique Barboza
On 11/1/24 2:35 PM, Daniel Henrique Barboza wrote: On 11/1/24 2:08 PM, Pierrick Bouvier wrote: Introduced in 0c54ac, "hw/riscv: add RISC-V IOMMU base emulation" ../hw/riscv/riscv-iommu.c:187:17: error: redefinition of '_pext_u64'    187 | static uint64_t _pext_u64(uint64_t val, uint64_t e

Re: [PATCH] hw/riscv: fix build error with clang

2024-11-01 Thread Daniel Henrique Barboza
On 11/1/24 2:08 PM, Pierrick Bouvier wrote: Introduced in 0c54ac, "hw/riscv: add RISC-V IOMMU base emulation" ../hw/riscv/riscv-iommu.c:187:17: error: redefinition of '_pext_u64' 187 | static uint64_t _pext_u64(uint64_t val, uint64_t ext) | ^ D:/a/_temp/msys64/cla

[PATCH] hw/riscv: fix build error with clang

2024-11-01 Thread Pierrick Bouvier
Introduced in 0c54ac, "hw/riscv: add RISC-V IOMMU base emulation" ../hw/riscv/riscv-iommu.c:187:17: error: redefinition of '_pext_u64' 187 | static uint64_t _pext_u64(uint64_t val, uint64_t ext) | ^ D:/a/_temp/msys64/clang64/lib/clang/18/include/bmi2intrin.h:217:1: note: