Re: [PATCH] hw/riscv: Fix type conflict of GLib function pointers

On Fri, Apr 11, 2025 at 2:19 AM Paolo Bonzini wrote: > > qtest_set_command_cb passed to g_once should match GThreadFunc, > which it does not. But using g_once is actually unnecessary, > because the function is called by riscv_harts_realize() under > the Big QEMU Lock. > > Reported-by: Kohei Tokun

Re: [PATCH] hw/riscv: Fix type conflict of GLib function pointers

On Fri, Apr 11, 2025 at 2:19 AM Paolo Bonzini wrote: > > qtest_set_command_cb passed to g_once should match GThreadFunc, > which it does not. But using g_once is actually unnecessary, > because the function is called by riscv_harts_realize() under > the Big QEMU Lock. > > Reported-by: Kohei Tokun

Re: [PATCH] hw/riscv: Fix type conflict of GLib function pointers

On 10/4/25 18:17, Paolo Bonzini wrote: qtest_set_command_cb passed to g_once should match GThreadFunc, which it does not. But using g_once is actually unnecessary, because the function is called by riscv_harts_realize() under the Big QEMU Lock. Reported-by: Kohei Tokunaga Signed-off-by: Paolo

Re: [PATCH] hw/riscv: Fix type conflict of GLib function pointers

Hi Paolo, I appreciate you addressing this issue and submitting the fix. Reviewed-by: Kohei Tokunaga

[PATCH] hw/riscv: Fix type conflict of GLib function pointers

qtest_set_command_cb passed to g_once should match GThreadFunc, which it does not. But using g_once is actually unnecessary, because the function is called by riscv_harts_realize() under the Big QEMU Lock. Reported-by: Kohei Tokunaga Signed-off-by: Paolo Bonzini --- hw/riscv/riscv_hart.c | 7 +