Re: [PATCH] hw/pci-host/grackle: Verify PIC link is properly set

2020-10-21 Thread BALATON Zoltan via
On Wed, 21 Oct 2020, Markus Armbruster wrote: BALATON Zoltan via writes: On Tue, 20 Oct 2020, Markus Armbruster wrote: Mark Cave-Ayland writes: One thing I have thought about is being able to mark a link property as mandatory so if a value hasn't been set before realize then you A non-nul

Re: [PATCH] hw/pci-host/grackle: Verify PIC link is properly set

2020-10-20 Thread Markus Armbruster
BALATON Zoltan via writes: > On Tue, 20 Oct 2020, Markus Armbruster wrote: >> Mark Cave-Ayland writes: >> >>> One thing I have thought about is being able to mark a link property >>> as mandatory so if a value hasn't been set before realize then you >> >> A non-null value, I presume. > > Do you

Re: [PATCH] hw/pci-host/grackle: Verify PIC link is properly set

2020-10-20 Thread BALATON Zoltan via
On Tue, 20 Oct 2020, Markus Armbruster wrote: Mark Cave-Ayland writes: One thing I have thought about is being able to mark a link property as mandatory so if a value hasn't been set before realize then you A non-null value, I presume. Do you mean something like distinguish between NULL an

Re: [PATCH] hw/pci-host/grackle: Verify PIC link is properly set

2020-10-19 Thread Markus Armbruster
Mark Cave-Ayland writes: > One thing I have thought about is being able to mark a link property > as mandatory so if a value hasn't been set before realize then you A non-null value, I presume. > receive a fatal error. This would be for cases like this where 2 > internal devices are connected t

Re: [PATCH] hw/pci-host/grackle: Verify PIC link is properly set

2020-10-19 Thread BALATON Zoltan via
On Mon, 19 Oct 2020, Mark Cave-Ayland wrote: On 19/10/2020 15:00, Markus Armbruster wrote: BALATON Zoltan via writes: On Mon, 19 Oct 2020, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: On 10/12/20 1:50 PM, BALATON Zoltan via wrote: On Mon, 12 Oct 2020, David Gibson wrote: On Mon

Re: [PATCH] hw/pci-host/grackle: Verify PIC link is properly set

2020-10-19 Thread Mark Cave-Ayland
On 19/10/2020 15:00, Markus Armbruster wrote: BALATON Zoltan via writes: On Mon, 19 Oct 2020, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: On 10/12/20 1:50 PM, BALATON Zoltan via wrote: On Mon, 12 Oct 2020, David Gibson wrote: On Mon, Oct 12, 2020 at 08:21:41AM +0200, Philippe

Re: [PATCH] hw/pci-host/grackle: Verify PIC link is properly set

2020-10-19 Thread Markus Armbruster
BALATON Zoltan via writes: > On Mon, 19 Oct 2020, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >>> On 10/12/20 1:50 PM, BALATON Zoltan via wrote: On Mon, 12 Oct 2020, David Gibson wrote: > On Mon, Oct 12, 2020 at 08:21:41AM +0200, Philippe > Mathieu-Daudé wrote:

Re: [PATCH] hw/pci-host/grackle: Verify PIC link is properly set

2020-10-19 Thread BALATON Zoltan via
On Mon, 19 Oct 2020, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: On 10/12/20 1:50 PM, BALATON Zoltan via wrote: On Mon, 12 Oct 2020, David Gibson wrote: On Mon, Oct 12, 2020 at 08:21:41AM +0200, Philippe Mathieu-Daudé wrote: On 10/12/20 12:34 AM, David Gibson wrote: On Su

Re: [PATCH] hw/pci-host/grackle: Verify PIC link is properly set

2020-10-19 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 10/12/20 1:50 PM, BALATON Zoltan via wrote: >> On Mon, 12 Oct 2020, David Gibson wrote: >>> On Mon, Oct 12, 2020 at 08:21:41AM +0200, Philippe >>> Mathieu-Daudé wrote: On 10/12/20 12:34 AM, David Gibson wrote: > On Sun, Oct 11, 2020 at 09:03:32P

Re: [PATCH] hw/pci-host/grackle: Verify PIC link is properly set

2020-10-12 Thread Philippe Mathieu-Daudé
On 10/12/20 1:50 PM, BALATON Zoltan via wrote: On Mon, 12 Oct 2020, David Gibson wrote: On Mon, Oct 12, 2020 at 08:21:41AM +0200, Philippe Mathieu-Daudé wrote: On 10/12/20 12:34 AM, David Gibson wrote: On Sun, Oct 11, 2020 at 09:03:32PM +0200, Philippe Mathieu-Daudé wrote: The Grackle P

Re: [PATCH] hw/pci-host/grackle: Verify PIC link is properly set

2020-10-12 Thread Philippe Mathieu-Daudé
On 10/12/20 11:23 AM, Mark Cave-Ayland wrote: On 11/10/2020 20:03, Philippe Mathieu-Daudé wrote: The Grackle PCI host model expects the interrupt controller being set, but does not verify it is present. Add a check to help developers using this model. Signed-off-by: Philippe Mathieu-Daudé ---

Re: [PATCH] hw/pci-host/grackle: Verify PIC link is properly set

2020-10-12 Thread BALATON Zoltan via
On Mon, 12 Oct 2020, David Gibson wrote: On Mon, Oct 12, 2020 at 08:21:41AM +0200, Philippe Mathieu-Daudé wrote: On 10/12/20 12:34 AM, David Gibson wrote: On Sun, Oct 11, 2020 at 09:03:32PM +0200, Philippe Mathieu-Daudé wrote: The Grackle PCI host model expects the interrupt controller being s

Re: [PATCH] hw/pci-host/grackle: Verify PIC link is properly set

2020-10-12 Thread Mark Cave-Ayland
On 11/10/2020 20:03, Philippe Mathieu-Daudé wrote: > The Grackle PCI host model expects the interrupt controller > being set, but does not verify it is present. Add a check to > help developers using this model. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/pci-host/grackle.c | 4 >

Re: [PATCH] hw/pci-host/grackle: Verify PIC link is properly set

2020-10-12 Thread David Gibson
On Mon, Oct 12, 2020 at 08:21:41AM +0200, Philippe Mathieu-Daudé wrote: > On 10/12/20 12:34 AM, David Gibson wrote: > > On Sun, Oct 11, 2020 at 09:03:32PM +0200, Philippe Mathieu-Daudé wrote: > > > The Grackle PCI host model expects the interrupt controller > > > being set, but does not verify it i

Re: [PATCH] hw/pci-host/grackle: Verify PIC link is properly set

2020-10-11 Thread Philippe Mathieu-Daudé
On 10/12/20 12:34 AM, David Gibson wrote: On Sun, Oct 11, 2020 at 09:03:32PM +0200, Philippe Mathieu-Daudé wrote: The Grackle PCI host model expects the interrupt controller being set, but does not verify it is present. Add a check to help developers using this model. I don't think thaqt's ver

Re: [PATCH] hw/pci-host/grackle: Verify PIC link is properly set

2020-10-11 Thread David Gibson
On Sun, Oct 11, 2020 at 09:03:32PM +0200, Philippe Mathieu-Daudé wrote: > The Grackle PCI host model expects the interrupt controller > being set, but does not verify it is present. Add a check to > help developers using this model. I don't think thaqt's very likely, but, sure, applied to ppc-for-

[PATCH] hw/pci-host/grackle: Verify PIC link is properly set

2020-10-11 Thread Philippe Mathieu-Daudé
The Grackle PCI host model expects the interrupt controller being set, but does not verify it is present. Add a check to help developers using this model. Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/grackle.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/pci-host/grackle.c