Re: [PATCH] hw/pci: Add parenthesis to PCI_BUILD_BDF macro

2024-11-03 Thread Philippe Mathieu-Daudé
On 1/11/24 18:59, Roque Arcudia Hernandez wrote: The bus parameter in the macro PCI_BUILD_BDF is not surrounded by parenthesis. This can create a compile error when warnings are treated as errors or can potentially create runtime errors due to the operator precedence. For instance: file.c:x:3

[PATCH] hw/pci: Add parenthesis to PCI_BUILD_BDF macro

2024-11-01 Thread Roque Arcudia Hernandez
The bus parameter in the macro PCI_BUILD_BDF is not surrounded by parenthesis. This can create a compile error when warnings are treated as errors or can potentially create runtime errors due to the operator precedence. For instance: file.c:x:32: error: suggest parentheses around '-' inside '<<'