Re: [External] Re: [PATCH] hw/pci/pcie.c: Fix invalid PCI_EXP_LNKCAP setting

2022-05-19 Thread Wenliang Wang
As PCI_EXP_LNKCAP is never masked when loading, this patch does affect cross version migration. It seems we need machine type compat to deal with that. What do you suggest, Michael? On 5/20/22 12:49 AM, Michael S. Tsirkin wrote: On Thu, May 19, 2022 at 10:45:59PM +0800, Wenliang Wang wrote: p

[PATCH] hw/pci/pcie.c: Fix invalid PCI_EXP_LNKCAP setting

2022-05-19 Thread Wenliang Wang
pcie_cap_fill_slot_lnk() wrongly set PCI_EXP_LNKCAP when slot speed and width is not set, causing strange downstream port link cap (Speed unknown, Width x0) and pcie devices native hotplug error on Linux: [3.545654] pcieport :02:00.0: pciehp: link training error: status 0x2000 [3.54714

Re: [PATCH] hw/pci/pcie.c: Fix invalid PCI_EXP_LNKCAP setting

2022-05-19 Thread Michael S. Tsirkin
On Thu, May 19, 2022 at 10:45:59PM +0800, Wenliang Wang wrote: > pcie_cap_fill_slot_lnk() wrongly set PCI_EXP_LNKCAP when slot speed > and width is not set, causing strange downstream port link cap > (Speed unknown, Width x0) and pcie devices native hotplug error on Linux: > > [3.545654] pciep