Re: [PATCH] hw/net: Fix read of uninitialized memory in ftgmac100

2023-01-09 Thread Cédric Le Goater
On 1/9/23 18:50, Stephen Longfield wrote: Does anything more need to happen with this patch before it can be applied? Not sure if it had gotten lost over the holidays. I queued it with other aspeed changes : https://github.com/legoater/qemu/commits/aspeed-8.0 We have some time before 8.0 is

Re: [PATCH] hw/net: Fix read of uninitialized memory in ftgmac100

2023-01-09 Thread Stephen Longfield
Does anything more need to happen with this patch before it can be applied? Not sure if it had gotten lost over the holidays. Best, --Stephen On Wed, Dec 21, 2022 at 9:58 AM Stephen Longfield wrote: > > On Tue, Dec 20, 2022 at 11:30 PM Cédric Le Goater wrote: > > > > On 12/20/22 23:14, Stephe

Re: [PATCH] hw/net: Fix read of uninitialized memory in ftgmac100

2022-12-21 Thread Stephen Longfield
On Tue, Dec 20, 2022 at 11:30 PM Cédric Le Goater wrote: > > On 12/20/22 23:14, Stephen Longfield wrote: > > With the `size += 4` before the call to `crc32`, the CRC calculation > > would overrun the buffer. Size is used in the while loop starting on > > line 1009 to determine how much data to wri

Re: [PATCH] hw/net: Fix read of uninitialized memory in ftgmac100

2022-12-20 Thread Cédric Le Goater
On 12/20/22 23:14, Stephen Longfield wrote: With the `size += 4` before the call to `crc32`, the CRC calculation would overrun the buffer. Size is used in the while loop starting on line 1009 to determine how much data to write back, with the last four bytes coming from `crc_ptr`, so do need to i

[PATCH] hw/net: Fix read of uninitialized memory in ftgmac100

2022-12-20 Thread Stephen Longfield
With the `size += 4` before the call to `crc32`, the CRC calculation would overrun the buffer. Size is used in the while loop starting on line 1009 to determine how much data to write back, with the last four bytes coming from `crc_ptr`, so do need to increase it, but should do this after the compu