Re: [PATCH] hw/net/dp8393x: fix integer underflow in dp8393x_do_transmit_packets()

2020-12-01 Thread Peter Maydell
On Tue, 1 Dec 2020 at 05:46, Jason Wang wrote: > > > On 2020/11/30 下午8:11, Mauro Matteo Cascella wrote: > > On Mon, Nov 30, 2020 at 11:44 AM Philippe Mathieu-Daudé > > wrote: > >> +Laurent/Finn > >> > >> On 11/24/20 10:24 AM, Mauro Matteo Cascella wrote: > >>> An integer underflow could occur du

Re: [PATCH] hw/net/dp8393x: fix integer underflow in dp8393x_do_transmit_packets()

2020-11-30 Thread Jason Wang
On 2020/11/30 下午8:11, Mauro Matteo Cascella wrote: On Mon, Nov 30, 2020 at 11:44 AM Philippe Mathieu-Daudé wrote: +Laurent/Finn On 11/24/20 10:24 AM, Mauro Matteo Cascella wrote: An integer underflow could occur during packet transmission due to 'tx_len' not being updated if SONIC_TFC regis

Re: [PATCH] hw/net/dp8393x: fix integer underflow in dp8393x_do_transmit_packets()

2020-11-30 Thread Mauro Matteo Cascella
On Mon, Nov 30, 2020 at 11:44 AM Philippe Mathieu-Daudé wrote: > > +Laurent/Finn > > On 11/24/20 10:24 AM, Mauro Matteo Cascella wrote: > > An integer underflow could occur during packet transmission due to 'tx_len' > > not > > being updated if SONIC_TFC register is set to zero. Check for negativ

Re: [PATCH] hw/net/dp8393x: fix integer underflow in dp8393x_do_transmit_packets()

2020-11-30 Thread Philippe Mathieu-Daudé
+Laurent/Finn On 11/24/20 10:24 AM, Mauro Matteo Cascella wrote: > An integer underflow could occur during packet transmission due to 'tx_len' > not > being updated if SONIC_TFC register is set to zero. Check for negative > 'tx_len' > when removing existing FCS. > > RHBZ: https://bugzilla.redha

[PATCH] hw/net/dp8393x: fix integer underflow in dp8393x_do_transmit_packets()

2020-11-24 Thread Mauro Matteo Cascella
An integer underflow could occur during packet transmission due to 'tx_len' not being updated if SONIC_TFC register is set to zero. Check for negative 'tx_len' when removing existing FCS. RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1899722 Signed-off-by: Mauro Matteo Cascella Reported-by: G