Re: [PATCH] hw/ipmi: Don't call vmstate_register() from instance_init() functions

2023-10-23 Thread Corey Minyard
On Mon, Oct 23, 2023 at 01:30:09PM +0200, Juan Quintela wrote: > Thomas Huth wrote: > > instance_init() can be called multiple times, e.g. during introspection > > of the device. We should not install the vmstate handlers here. Do it > > in the realize() function instead. > > > > Signed-off-by: Th

Re: [PATCH] hw/ipmi: Don't call vmstate_register() from instance_init() functions

2023-10-23 Thread Juan Quintela
Thomas Huth wrote: > instance_init() can be called multiple times, e.g. during introspection > of the device. We should not install the vmstate handlers here. Do it > in the realize() function instead. > > Signed-off-by: Thomas Huth Reviewed-by: Juan Quintela It fixes my issues. Should I take

[PATCH] hw/ipmi: Don't call vmstate_register() from instance_init() functions

2023-10-20 Thread Thomas Huth
instance_init() can be called multiple times, e.g. during introspection of the device. We should not install the vmstate handlers here. Do it in the realize() function instead. Signed-off-by: Thomas Huth --- hw/ipmi/ipmi_bmc_extern.c | 29 +++ hw/ipmi/isa_ipmi_bt.c | 34 +