Re: [PATCH] hw/ide: implement ich6 ide controller support

2022-02-17 Thread John Snow
On Mon, Feb 14, 2022 at 1:48 PM Liav Albani wrote: > > Hello BALATON, > > Thank you for helping keeping this patch noticeable to everyone :) > > I tried to reach out to John via a private email last Saturday (two days > ago) so I don't "spam" the mailing list for no good reason. > It might be that

Re: [PATCH] hw/ide: implement ich6 ide controller support

2022-02-14 Thread Liav Albani
Hello BALATON, Thank you for helping keeping this patch noticeable to everyone :) I tried to reach out to John via a private email last Saturday (two days ago) so I don't "spam" the mailing list for no good reason. It might be that I should actually refrain from doing so and talk to the mainta

Re: [PATCH] hw/ide: implement ich6 ide controller support

2022-02-14 Thread BALATON Zoltan
On Sat, 5 Feb 2022, BALATON Zoltan wrote: Hello, Ping? John, do you agree with my comments? Should Liav proceed to send a v2? Thanks, BALATON Zoltan On Sat, 5 Feb 2022, Liav Albani wrote: On 2/5/22 17:48, BALATON Zoltan wrote: On Sat, 5 Feb 2022, Liav Albani wrote: This type of IDE cont

Re: [PATCH] hw/ide: implement ich6 ide controller support

2022-02-05 Thread BALATON Zoltan
Hello, On Sat, 5 Feb 2022, Liav Albani wrote: On 2/5/22 17:48, BALATON Zoltan wrote: On Sat, 5 Feb 2022, Liav Albani wrote: This type of IDE controller has support for relocating the IO ports and doesn't use IRQ 14 and 15 but one allocated PCI IRQ for the controller. I haven't looked at in d

Re: [PATCH] hw/ide: implement ich6 ide controller support

2022-02-05 Thread Liav Albani
On 2/5/22 17:48, BALATON Zoltan wrote: On Sat, 5 Feb 2022, Liav Albani wrote: This type of IDE controller has support for relocating the IO ports and doesn't use IRQ 14 and 15 but one allocated PCI IRQ for the controller. I haven't looked at in detail so only a few comments I've got while r

Re: [PATCH] hw/ide: implement ich6 ide controller support

2022-02-05 Thread BALATON Zoltan
On Sat, 5 Feb 2022, Liav Albani wrote: This type of IDE controller has support for relocating the IO ports and doesn't use IRQ 14 and 15 but one allocated PCI IRQ for the controller. I haven't looked at in detail so only a few comments I've got while reading it. What machine needs this? In QEM

[PATCH] hw/ide: implement ich6 ide controller support

2022-02-05 Thread Liav Albani
This type of IDE controller has support for relocating the IO ports and doesn't use IRQ 14 and 15 but one allocated PCI IRQ for the controller. Signed-off-by: Liav Albani --- hw/i386/Kconfig | 2 + hw/ide/Kconfig | 5 + hw/ide/bmdma.c | 83 +++ hw/id