Re: [PATCH] hw/i386: introduce x86_firmware_reconfigure api

2025-02-25 Thread Gerd Hoffmann
On Tue, Feb 25, 2025 at 09:10:40AM +0530, Ani Sinha wrote: > On Mon, Feb 24, 2025 at 9:01 PM Gerd Hoffmann wrote: > > > > Hi, > > > > > /* should only be called once */ > > > -if (ovmf_flash_parsed) { > > > +if (ovmf_flash_parsed && !force) { > > > > I think it makes more sense to c

Re: [PATCH] hw/i386: introduce x86_firmware_reconfigure api

2025-02-24 Thread Ani Sinha
On Mon, Feb 24, 2025 at 9:01 PM Gerd Hoffmann wrote: > > Hi, > > > /* should only be called once */ > > -if (ovmf_flash_parsed) { > > +if (ovmf_flash_parsed && !force) { > > I think it makes more sense to clear ovmf_flash_parsed when replacing > the firmware (instead of adding the f

Re: [PATCH] hw/i386: introduce x86_firmware_reconfigure api

2025-02-24 Thread Gerd Hoffmann
Hi, > /* should only be called once */ > -if (ovmf_flash_parsed) { > +if (ovmf_flash_parsed && !force) { I think it makes more sense to clear ovmf_flash_parsed when replacing the firmware (instead of adding the force override). take care, Gerd

[PATCH] hw/i386: introduce x86_firmware_reconfigure api

2025-02-20 Thread Ani Sinha
Normally, there is no need to perform firmware reconfiguration once the virtal machine has started. Hence, currently ovmf firmware parsing happens only once. However, if the firmware changes betweeen boots then reconfiguration needs to happen again. Firmware can change if for example the guest brin