Re: [PATCH] hw/core/machine: Add the missing delimiter in cpu_slot_to_string()

2021-10-26 Thread Laurent Vivier
Le 26/10/2021 à 14:55, wangyanan (Y) a écrit : On 2021/10/19 16:23, Laurent Vivier wrote: Le 08/10/2021 à 09:50, Yanan Wang a écrit : The expected output string from cpu_slot_to_string() ought to be like "socket-id: *, die-id: *, core-id: *, thread-id: *", so add the missing ", " before "die-i

Re: [PATCH] hw/core/machine: Add the missing delimiter in cpu_slot_to_string()

2021-10-26 Thread wangyanan (Y)
On 2021/10/19 16:23, Laurent Vivier wrote: Le 08/10/2021 à 09:50, Yanan Wang a écrit : The expected output string from cpu_slot_to_string() ought to be like "socket-id: *, die-id: *, core-id: *, thread-id: *", so add the missing ", " before "die-id". This affects the readability of the error m

Re: [PATCH] hw/core/machine: Add the missing delimiter in cpu_slot_to_string()

2021-10-19 Thread Laurent Vivier
Le 08/10/2021 à 09:50, Yanan Wang a écrit : > The expected output string from cpu_slot_to_string() ought to be > like "socket-id: *, die-id: *, core-id: *, thread-id: *", so add > the missing ", " before "die-id". This affects the readability > of the error message. > > Fixes: 176d2cda0d ("i386/cp

Re: [PATCH] hw/core/machine: Add the missing delimiter in cpu_slot_to_string()

2021-10-19 Thread wangyanan (Y)
Cc'ing qemu-triv...@nongnu.org. What about this simple one ? Before this patch, with "-smp 4, dies=2" for a PC machine, we will generate warn strings like: qemu-system-x86_64: warning: CPU(s) not present in any NUMA nodes: CPU 0 [socket-id: 0die-id: 0, core-id: 0, thread-id: 0] After we will

[PATCH] hw/core/machine: Add the missing delimiter in cpu_slot_to_string()

2021-10-08 Thread Yanan Wang
The expected output string from cpu_slot_to_string() ought to be like "socket-id: *, die-id: *, core-id: *, thread-id: *", so add the missing ", " before "die-id". This affects the readability of the error message. Fixes: 176d2cda0d ("i386/cpu: Consolidate die-id validity in smp context") Signed-o