Re: [PATCH] hw/char/stm32l4x5_usart.c: Fix ACK and min access size

2024-10-08 Thread Peter Maydell
On Sat, 14 Sept 2024 at 04:42, Jacob Abrams wrote: > I have received a response from my contact Nicolas Fillon at STM, he wrote "I > see we are making 16 bit access read and write to these 16 bit registers in > our library for both HAL and LL so this should be a documentation issue." Thanks for

Re: [PATCH] hw/char/stm32l4x5_usart.c: Fix ACK and min access size

2024-09-13 Thread Jacob Abrams
On 9/11/24 03:28, Peter Maydell wrote: > On Wed, 11 Sept 2024 at 07:27, Jacob Abrams wrote: >> On 9/10/24 02:34, Peter Maydell wrote: >>> If we make the .impl and .valid changes, then the result is >>> that we permit 16 bit writes to come through to the read >>> and write functions. Since we do

Re: [PATCH] hw/char/stm32l4x5_usart.c: Fix ACK and min access size

2024-09-11 Thread Peter Maydell
On Wed, 11 Sept 2024 at 07:27, Jacob Abrams wrote: > On 9/10/24 02:34, Peter Maydell wrote: > > If we make the .impl and .valid changes, then the result is > > that we permit 16 bit writes to come through to the read > > and write functions. Since we don't make any changes to > > those functions t

Re: [PATCH] hw/char/stm32l4x5_usart.c: Fix ACK and min access size

2024-09-10 Thread Jacob Abrams
On 9/10/24 02:34, Peter Maydell wrote: > On Mon, 9 Sept 2024 at 18:40, Philippe Mathieu-Daudé > wrote: >> >> Hi, >> >> (Cc'ing Arnaud & Inès who are listed as maintainers) >> >> On 6/9/24 18:12, Peter Maydell wrote: >>> On Mon, 2 Sept 2024 at 14:38, Jacob Abrams wrote: These changes

Re: [PATCH] hw/char/stm32l4x5_usart.c: Fix ACK and min access size

2024-09-10 Thread Peter Maydell
On Mon, 9 Sept 2024 at 18:40, Philippe Mathieu-Daudé wrote: > > Hi, > > (Cc'ing Arnaud & Inès who are listed as maintainers) > > On 6/9/24 18:12, Peter Maydell wrote: > > On Mon, 2 Sept 2024 at 14:38, Jacob Abrams wrote: > >> > >> These changes allow the official STM32L4xx HAL UART driver to func

Re: [PATCH] hw/char/stm32l4x5_usart.c: Fix ACK and min access size

2024-09-09 Thread Philippe Mathieu-Daudé
Hi Jacob, On 10/9/24 06:34, Jacob Abrams wrote: On 9/9/24 10:40, Philippe Mathieu-Daudé wrote: Hi, (Cc'ing Arnaud & Inès who are listed as maintainers) On 6/9/24 18:12, Peter Maydell wrote: On Mon, 2 Sept 2024 at 14:38, Jacob Abrams wrote: These changes allow the official STM32L4xx HAL UA

Re: [PATCH] hw/char/stm32l4x5_usart.c: Fix ACK and min access size

2024-09-09 Thread Jacob Abrams
On 9/9/24 10:40, Philippe Mathieu-Daudé wrote: > Hi, > > (Cc'ing Arnaud & Inès who are listed as maintainers) > > On 6/9/24 18:12, Peter Maydell wrote: >> On Mon, 2 Sept 2024 at 14:38, Jacob Abrams wrote: >>> >>> These changes allow the official STM32L4xx HAL UART driver to function >>> prope

Re: [PATCH] hw/char/stm32l4x5_usart.c: Fix ACK and min access size

2024-09-09 Thread Philippe Mathieu-Daudé
Hi, (Cc'ing Arnaud & Inès who are listed as maintainers) On 6/9/24 18:12, Peter Maydell wrote: On Mon, 2 Sept 2024 at 14:38, Jacob Abrams wrote: These changes allow the official STM32L4xx HAL UART driver to function properly with the b-l475e-iot01a machine. Modifying USART_CR1 TE bit should

Re: [PATCH] hw/char/stm32l4x5_usart.c: Fix ACK and min access size

2024-09-07 Thread Jacob Abrams
On 9/6/24 09:12, Peter Maydell wrote: > On Mon, 2 Sept 2024 at 14:38, Jacob Abrams wrote: >> >> These changes allow the official STM32L4xx HAL UART driver to function >> properly with the b-l475e-iot01a machine. >> >> Modifying USART_CR1 TE bit should alter USART_ISR TEACK bit, and >> likewise for

Re: [PATCH] hw/char/stm32l4x5_usart.c: Fix ACK and min access size

2024-09-06 Thread Peter Maydell
On Mon, 2 Sept 2024 at 14:38, Jacob Abrams wrote: > > These changes allow the official STM32L4xx HAL UART driver to function > properly with the b-l475e-iot01a machine. > > Modifying USART_CR1 TE bit should alter USART_ISR TEACK bit, and > likewise for RE and REACK bit. > > USART registers may be

[PATCH] hw/char/stm32l4x5_usart.c: Fix ACK and min access size

2024-09-02 Thread Jacob Abrams
These changes allow the official STM32L4xx HAL UART driver to function properly with the b-l475e-iot01a machine. Modifying USART_CR1 TE bit should alter USART_ISR TEACK bit, and likewise for RE and REACK bit. USART registers may be accessed via 16-bit instructions. Reseting USART_CR1 UE bit shou