Re: [PATCH] hw/char/serial: Convert to three-phase reset

2025-01-10 Thread Philippe Mathieu-Daudé
On 10/1/25 19:12, Paolo Bonzini wrote: On 1/10/25 18:57, Philippe Mathieu-Daudé wrote: Convert the TYPE_SERIAL (16550A UART) to three-phase reset. Local states are reset in the ResetHold handler. Move the IRQ lowering to ResetExit, since it an external object is accessed. Accessing external o

Re: [PATCH] hw/char/serial: Convert to three-phase reset

2025-01-10 Thread Paolo Bonzini
On 1/10/25 18:57, Philippe Mathieu-Daudé wrote: Convert the TYPE_SERIAL (16550A UART) to three-phase reset. Local states are reset in the ResetHold handler. Move the IRQ lowering to ResetExit, since it an external object is accessed. Accessing external objects is fine for hold; only "enter" ca

[PATCH] hw/char/serial: Convert to three-phase reset

2025-01-10 Thread Philippe Mathieu-Daudé
Convert the TYPE_SERIAL (16550A UART) to three-phase reset. Local states are reset in the ResetHold handler. Move the IRQ lowering to ResetExit, since it an external object is accessed. Note, this fixes a bug where serial_realize() was calling serial_reset() -> qemu_irq_lower() while the IRQ was n