Re: Re: [PATCH] hw/char/riscv_htif: Fix htif_mm_write that causes infinite loop in ACT.

2024-10-16 Thread Alistair Francis
On Wed, Oct 16, 2024 at 8:32 PM Trd thg wrote: > > Sorry about the email style, I'm not familiar with it yet No worries! It takes some getting used to. Mostly just plain text emails and reply inline :) Alistair > > > It's probably worth including this in the commit message. > Agree, I'll do it.

Fwd: Re: [PATCH] hw/char/riscv_htif: Fix htif_mm_write that causes infinite loop in ACT.

2024-10-16 Thread Trd thg
Sorry about the email style, I'm not familiar with it yet > It's probably worth including this in the commit message. Agree, I'll do it. > It would be good to reference the sail implementation and the justification for the change there Sail implementation is probably here: https://github.com/ris

Re: Re: [PATCH] hw/char/riscv_htif: Fix htif_mm_write that causes infinite loop in ACT.

2024-10-15 Thread Alistair Francis
On Mon, Oct 14, 2024 at 8:08 PM 阎明铸 wrote: > > Thank you for your reply and I'm sorry that I didn't explain it clearly. > > - ACT is an official riscv test suite to check the riscv support of the > DUT(device under test). It's probably worth including this in the commit message. > - Currently A

Re: Re: [PATCH] hw/char/riscv_htif: Fix htif_mm_write that causes infinite loop in ACT.

2024-10-14 Thread 阎明铸
Thank you for your reply and I'm sorry that I didn't explain it clearly. - ACT is an official riscv test suite to check the riscv support of the DUT(device under test). - Currently ACT support using [sail-riscv](https://github.com/riscv/sail-riscv)(default) or [spike](https://github.com/riscv-s

Re: [PATCH] hw/char/riscv_htif: Fix htif_mm_write that causes infinite loop in ACT.

2024-10-01 Thread Alistair Francis
On Fri, Sep 27, 2024 at 11:26 PM MingZhu Yan wrote: > > Applications sometimes only write the lower 32-bit payload bytes, this is used > in ACT tests. As a workaround, this refers to the solution of sail-riscv. I'm not sure what ACT is, but this feels like a guest bug, not a QEMU issue. Alistair

[PATCH] hw/char/riscv_htif: Fix htif_mm_write that causes infinite loop in ACT.

2024-09-27 Thread MingZhu Yan
Applications sometimes only write the lower 32-bit payload bytes, this is used in ACT tests. As a workaround, this refers to the solution of sail-riscv. if the payload is written a few times with the same value, we process the whole htif command anyway. Signed-off-by: MingZhu Yan --- hw/char/ris

[PATCH] hw/char/riscv_htif: Fix htif_mm_write that causes infinite loop in ACT.

2024-09-27 Thread MingZhu Yan
Applications sometimes only write the lower 32-bit payload bytes, this is used in ACT tests. As a workaround, this refers to the solution of sail-riscv. if the payload is written a few times with the same value, we process the whole htif command anyway. Signed-off-by: MingZhu Yan --- hw/char/ris