Re: [PATCH] hw/boards: Convert MachineClass bitfields to boolean

2025-01-22 Thread Pierrick Bouvier
On 1/22/25 02:32, Philippe Mathieu-Daudé wrote: As Daniel mentioned: "The number of instances of MachineClass is not large enough that we save a useful amount of memory through bitfields." Also, see recent commit ecbf3567e21 ("docs/devel/style: add a section about bitfield, and disallow th

Re: [PATCH] hw/boards: Convert MachineClass bitfields to boolean

2025-01-22 Thread Philippe Mathieu-Daudé
On 22/1/25 16:27, Thomas Huth wrote: On 22/01/2025 15.33, Peter Maydell wrote: On Wed, 22 Jan 2025 at 12:36, Thomas Huth wrote: On 22/01/2025 11.32, Philippe Mathieu-Daudé wrote: As Daniel mentioned:    "The number of instances of MachineClass is not large enough     that we save a useful a

Re: [PATCH] hw/boards: Convert MachineClass bitfields to boolean

2025-01-22 Thread Thomas Huth
On 22/01/2025 15.33, Peter Maydell wrote: On Wed, 22 Jan 2025 at 12:36, Thomas Huth wrote: On 22/01/2025 11.32, Philippe Mathieu-Daudé wrote: As Daniel mentioned: "The number of instances of MachineClass is not large enough that we save a useful amount of memory through bitfields." A

Re: [PATCH] hw/boards: Convert MachineClass bitfields to boolean

2025-01-22 Thread Peter Maydell
On Wed, 22 Jan 2025 at 12:36, Thomas Huth wrote: > > On 22/01/2025 11.32, Philippe Mathieu-Daudé wrote: > > As Daniel mentioned: > > > > "The number of instances of MachineClass is not large enough > >that we save a useful amount of memory through bitfields." > > > > Also, see recent commit

Re: [PATCH] hw/boards: Convert MachineClass bitfields to boolean

2025-01-22 Thread Thomas Huth
On 22/01/2025 11.32, Philippe Mathieu-Daudé wrote: As Daniel mentioned: "The number of instances of MachineClass is not large enough that we save a useful amount of memory through bitfields." Also, see recent commit ecbf3567e21 ("docs/devel/style: add a section about bitfield, and disallow

Re: [PATCH] hw/boards: Convert MachineClass bitfields to boolean

2025-01-22 Thread BALATON Zoltan
On Wed, 22 Jan 2025, Philippe Mathieu-Daudé wrote: As Daniel mentioned: "The number of instances of MachineClass is not large enough that we save a useful amount of memory through bitfields." Also, see recent commit ecbf3567e21 ("docs/devel/style: add a section about bitfield, and disallow the

Re: [PATCH] hw/boards: Convert MachineClass bitfields to boolean

2025-01-22 Thread Daniel P . Berrangé
On Wed, Jan 22, 2025 at 11:32:23AM +0100, Philippe Mathieu-Daudé wrote: > As Daniel mentioned: > > "The number of instances of MachineClass is not large enough > that we save a useful amount of memory through bitfields." > > Also, see recent commit ecbf3567e21 ("docs/devel/style: add a > secti

[PATCH] hw/boards: Convert MachineClass bitfields to boolean

2025-01-22 Thread Philippe Mathieu-Daudé
As Daniel mentioned: "The number of instances of MachineClass is not large enough that we save a useful amount of memory through bitfields." Also, see recent commit ecbf3567e21 ("docs/devel/style: add a section about bitfield, and disallow them for packed structures"). Convert the MachineClas