On 1/4/25 00:49, Philippe Mathieu-Daudé wrote:
Hi Joel,
On 19/11/24 11:29, Peter Maydell wrote:
On Tue, 19 Nov 2024 at 02:53, Joel Stanley wrote:
On Mon, 18 Nov 2024 at 20:40, Peter Maydell
wrote:
Have you reviewed all the device read/write function
implementations for these devices to ch
Hi Joel,
On 19/11/24 11:29, Peter Maydell wrote:
On Tue, 19 Nov 2024 at 02:53, Joel Stanley wrote:
On Mon, 18 Nov 2024 at 20:40, Peter Maydell wrote:
Have you reviewed all the device read/write function
implementations for these devices to check whether
(a) changing the .valid value does th
Hello Joel,
On 11/18/24 03:18, Joel Stanley wrote:
Guest code was performing a byte load to the SCU MMIO region, leading to
the guest code crashing (it should be using proper accessors, but
that is not Qemu's bug). Hardware and the documentation[1] both agree that
byte loads are okay, so change
On Tue, 19 Nov 2024 at 02:53, Joel Stanley wrote:
>
> On Mon, 18 Nov 2024 at 20:40, Peter Maydell wrote:
> > Have you reviewed all the device read/write function
> > implementations for these devices to check whether
> > (a) changing the .valid value does the right thing, or
>
> I read the implem
On Mon, 18 Nov 2024 at 20:40, Peter Maydell wrote:
>
> On Mon, 18 Nov 2024 at 02:19, Joel Stanley wrote:
> >
> > Guest code was performing a byte load to the SCU MMIO region, leading to
> > the guest code crashing (it should be using proper accessors, but
> > that is not Qemu's bug). Hardware and
On Mon, 18 Nov 2024 at 02:19, Joel Stanley wrote:
>
> Guest code was performing a byte load to the SCU MMIO region, leading to
> the guest code crashing (it should be using proper accessors, but
> that is not Qemu's bug). Hardware and the documentation[1] both agree that
> byte loads are okay, so
On Mon, Nov 18, 2024 at 10:18 AM Joel Stanley wrote:
>
> Guest code was performing a byte load to the SCU MMIO region, leading to
> the guest code crashing (it should be using proper accessors, but
> that is not Qemu's bug). Hardware and the documentation[1] both agree that
> byte loads are okay,
Guest code was performing a byte load to the SCU MMIO region, leading to
the guest code crashing (it should be using proper accessors, but
that is not Qemu's bug). Hardware and the documentation[1] both agree that
byte loads are okay, so change all of the aspeed devices to accept a
minimum access s
