Re: [PATCH] hw/arm: enable at24c with aspeed

2024-11-02 Thread Cédric Le Goater
On 10/28/24 19:14, Patrick Leis wrote: Enable AT24C with ASPEED in the KConfig because the boards build this device. Signed-off-by: Patrick Leis --- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index e7fd9338d1..1b25e73578 100644 --- a/hw

Re: [PATCH] hw/arm: enable at24c with aspeed

2024-10-28 Thread Philippe Mathieu-Daudé
On 28/10/24 15:14, Patrick Leis wrote: Enable AT24C with ASPEED in the KConfig because the boards build this device. Maybe explicit the at24c_eeprom_init_rom() call which instanciate TYPE_AT24C_EE. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Patrick Leis --- hw/arm/Kconfig | 1 +

Re: [PATCH] hw/arm: enable at24c with aspeed

2024-10-28 Thread Andrew Jeffery
On Mon, 2024-10-28 at 18:14 +, Patrick Leis wrote: > Enable AT24C with ASPEED in the KConfig because the boards build this > device. > > Signed-off-by: Patrick Leis I was wondering how we haven't hit problems before now. Poking around with scripts/minikconf.py for an arm-softmmu build we get

Re: [PATCH] hw/arm: enable at24c with aspeed

2024-10-28 Thread Hao Wu
On Mon, Oct 28, 2024 at 11:15 AM Patrick Leis wrote: > Enable AT24C with ASPEED in the KConfig because the boards build this > device. > > Signed-off-by: Patrick Leis > Reviewed-by: Hao Wu > --- > hw/arm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/arm/Kconfig b/hw/arm/

[PATCH] hw/arm: enable at24c with aspeed

2024-10-28 Thread Patrick Leis
Enable AT24C with ASPEED in the KConfig because the boards build this device. Signed-off-by: Patrick Leis --- hw/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig index e7fd9338d1..1b25e73578 100644 --- a/hw/arm/Kconfig +++ b/hw/arm/Kconfig @@ -539,6