Re: [PATCH] hw/arm/virt-acpi-build.c: Add missing header

2023-07-06 Thread Michael Tokarev
06.07.2023 18:08, Peng Liang wrote: virt-acpi-build.c uses warn_report. However, it doesn't include qemu/error-report.h directly, it include qemu/error-report.h via trace.h if we enable log trace backend. But if we disable the log trace backend (e.g., --enable-trace-backends=nop), then virt-acpi-

Re: [PATCH] hw/arm/virt-acpi-build.c: Add missing header

2023-07-06 Thread Philippe Mathieu-Daudé
On 6/7/23 17:08, Peng Liang wrote: virt-acpi-build.c uses warn_report. However, it doesn't include qemu/error-report.h directly, it include qemu/error-report.h via trace.h if we enable log trace backend. But if we disable the log trace backend (e.g., --enable-trace-backends=nop), then virt-acpi-b

Re: [PATCH] hw/arm/virt-acpi-build.c: Add missing header

2023-07-06 Thread Ani Sinha
> On 06-Jul-2023, at 8:38 PM, Peng Liang wrote: > > virt-acpi-build.c uses warn_report. However, it doesn't include > qemu/error-report.h directly, it include qemu/error-report.h via trace.h > if we enable log trace backend. But if we disable the log trace backend > (e.g., --enable-trace-backe

Re: [PATCH] hw/arm/virt-acpi-build.c: Add missing header

2023-07-06 Thread Peng Liang
I'm not sure whether the error has already been fixed by others or not. If so, please just ignore this patch. On 07/06/2023 23:08, Peng Liang wrote: virt-acpi-build.c uses warn_report. However, it doesn't include qemu/error-report.h directly, it include qemu/error-report.h via trace.h if we ena

[PATCH] hw/arm/virt-acpi-build.c: Add missing header

2023-07-06 Thread Peng Liang
virt-acpi-build.c uses warn_report. However, it doesn't include qemu/error-report.h directly, it include qemu/error-report.h via trace.h if we enable log trace backend. But if we disable the log trace backend (e.g., --enable-trace-backends=nop), then virt-acpi-build.c will not include qemu/error-re