Re: [PATCH] hw/acpi: some cosmetic improvements to existing code

2021-07-26 Thread Ani Sinha
> > > > diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c > > > > index f4d706e47d..856c6e1b47 100644 > > > > --- a/hw/acpi/pcihp.c > > > > +++ b/hw/acpi/pcihp.c > > > > @@ -136,6 +136,11 @@ static void acpi_pcihp_disable_root_bus(void) > > > > return; > > > > } > > > > > > > > +i

Re: [PATCH] hw/acpi: some cosmetic improvements to existing code

2021-07-26 Thread Ani Sinha
On Mon, 26 Jul 2021, Igor Mammedov wrote: > On Wed, 21 Jul 2021 19:46:10 +0530 > Ani Sinha wrote: > > > All existing code using acpi_get_i386_pci_host() checks for a non-null > > return from this function call. This change brings the same check to > > acpi_pcihp_disable_root_bus() function. Al

Re: [PATCH] hw/acpi: some cosmetic improvements to existing code

2021-07-26 Thread Igor Mammedov
On Mon, 26 Jul 2021 18:26:28 +0530 (IST) Ani Sinha wrote: > On Mon, 26 Jul 2021, Igor Mammedov wrote: > > > On Wed, 21 Jul 2021 19:46:10 +0530 > > Ani Sinha wrote: > > > > > All existing code using acpi_get_i386_pci_host() checks for a non-null > > > return from this function call. This chang

Re: [PATCH] hw/acpi: some cosmetic improvements to existing code

2021-07-26 Thread Ani Sinha
On Mon, 26 Jul 2021, Igor Mammedov wrote: > On Wed, 21 Jul 2021 19:46:10 +0530 > Ani Sinha wrote: > > > All existing code using acpi_get_i386_pci_host() checks for a non-null > > return from this function call. This change brings the same check to > > acpi_pcihp_disable_root_bus() function. Al

Re: [PATCH] hw/acpi: some cosmetic improvements to existing code

2021-07-26 Thread Igor Mammedov
On Wed, 21 Jul 2021 19:46:10 +0530 Ani Sinha wrote: > All existing code using acpi_get_i386_pci_host() checks for a non-null > return from this function call. This change brings the same check to > acpi_pcihp_disable_root_bus() function. Also adds a comment describing > why we unconditionally pas

Re: [PATCH] hw/acpi: some cosmetic improvements to existing code

2021-07-25 Thread Ani Sinha
ping ... On Wed, 21 Jul 2021, Ani Sinha wrote: > All existing code using acpi_get_i386_pci_host() checks for a non-null > return from this function call. This change brings the same check to > acpi_pcihp_disable_root_bus() function. Also adds a comment describing > why we unconditionally pass a t

[PATCH] hw/acpi: some cosmetic improvements to existing code

2021-07-21 Thread Ani Sinha
All existing code using acpi_get_i386_pci_host() checks for a non-null return from this function call. This change brings the same check to acpi_pcihp_disable_root_bus() function. Also adds a comment describing why we unconditionally pass a truth value to the last argument when calling acpi_pcihp_r

Re: [PATCH] hw/acpi: some cosmetic improvements to existing code

2021-07-21 Thread Ani Sinha
Please scratch this. I will resend with my nokia email removed. This work does not involve Nokia. Ani On Wed, 21 Jul 2021, Ani Sinha wrote: > From: Ani Sinha > > All existing code using acpi_get_i386_pci_host() checks for a non-null > return from this function call. This change brings the same

[PATCH] hw/acpi: some cosmetic improvements to existing code

2021-07-21 Thread Ani Sinha
From: Ani Sinha All existing code using acpi_get_i386_pci_host() checks for a non-null return from this function call. This change brings the same check to acpi_pcihp_disable_root_bus() function. Also adds a comment describing why we unconditionally pass a truth value to the last argument when ca