Re: [PATCH] hbitmap: fix hbitmap_status() return value for first dirty bit case

2023-02-16 Thread Kevin Wolf
Am 02.02.2023 um 19:15 hat Andrey Zhadchenko via geschrieben: > The last return statement should return true, as we already evaluated that > start == next_dirty > > Also, fix hbitmap_status() description in header > > Cc: qemu-sta...@nongnu.org > Fixes: a6426475a75 ("block/dirty-bitmap: introduce

Re: [PATCH] hbitmap: fix hbitmap_status() return value for first dirty bit case

2023-02-14 Thread Vladimir Sementsov-Ogievskiy
On 02.02.23 21:15, Andrey Zhadchenko via wrote: The last return statement should return true, as we already evaluated that start == next_dirty Also, fix hbitmap_status() description in header Cc: qemu-sta...@nongnu.org Fixes: a6426475a75 ("block/dirty-bitmap: introduce bdrv_dirty_bitmap_status(

Re: [PATCH] hbitmap: fix hbitmap_status() return value for first dirty bit case

2023-02-03 Thread Andrey Zhadchenko
On 2/3/23 13:55, Andrey Zhadchenko wrote: On 2/2/23 22:39, Eric Blake wrote: On Thu, Feb 02, 2023 at 09:15:23PM +0300, Andrey Zhadchenko via wrote: The last return statement should return true, as we already evaluated that start == next_dirty Also, fix hbitmap_status() description in head

Re: [PATCH] hbitmap: fix hbitmap_status() return value for first dirty bit case

2023-02-03 Thread Andrey Zhadchenko
On 2/2/23 22:39, Eric Blake wrote: On Thu, Feb 02, 2023 at 09:15:23PM +0300, Andrey Zhadchenko via wrote: The last return statement should return true, as we already evaluated that start == next_dirty Also, fix hbitmap_status() description in header Cc: qemu-sta...@nongnu.org Fixes: a6426475

Re: [PATCH] hbitmap: fix hbitmap_status() return value for first dirty bit case

2023-02-02 Thread Eric Blake
On Thu, Feb 02, 2023 at 09:15:23PM +0300, Andrey Zhadchenko via wrote: > The last return statement should return true, as we already evaluated that > start == next_dirty > > Also, fix hbitmap_status() description in header > > Cc: qemu-sta...@nongnu.org > Fixes: a6426475a75 ("block/dirty-bitmap:

[PATCH] hbitmap: fix hbitmap_status() return value for first dirty bit case

2023-02-02 Thread Andrey Zhadchenko via
The last return statement should return true, as we already evaluated that start == next_dirty Also, fix hbitmap_status() description in header Cc: qemu-sta...@nongnu.org Fixes: a6426475a75 ("block/dirty-bitmap: introduce bdrv_dirty_bitmap_status()") Signed-off-by: Andrey Zhadchenko --- include