Re: [PATCH] gdbstub: Switch to the thread receiving a signal

2021-10-19 Thread Pavel Labath
Thanks for taking a look. I've sent out a new version of the patch. Besides the Makefile change, I have also replaced the direct gdbserver_state manipulation with a call to gdb_set_stop_cpu. Further responses inline. On 19/10/2021 19:02, Alex Bennée wrote: Pavel Labath writes: Respond wit

Re: [PATCH] gdbstub: Switch to the thread receiving a signal

2021-10-19 Thread Alex Bennée
Pavel Labath writes: > On 15/10/2021 17:59, Alex Bennée wrote: >> Pavel Labath writes: >> >>> Ping. >>> >>> (This is my first qemu patch, so please let me know if I am doing >>> something wrong.) >> Apologies it slipped though the cracks. I shall have a look on >> Monday. >> > > I don't want

Re: [PATCH] gdbstub: Switch to the thread receiving a signal

2021-10-19 Thread Alex Bennée
Pavel Labath writes: > Respond with Txxthread:; instead of a plain Sxx to indicate which > thread received the signal. Otherwise, the debugger will associate it > with the main one. Also automatically select this thread, as that is > what gdb expects. > > Signed-off-by: Pavel Labath > ---

Re: [PATCH] gdbstub: Switch to the thread receiving a signal

2021-10-19 Thread Pavel Labath
On 15/10/2021 17:59, Alex Bennée wrote: Pavel Labath writes: Ping. (This is my first qemu patch, so please let me know if I am doing something wrong.) Apologies it slipped though the cracks. I shall have a look on Monday. I don't want to impose, but did this get buried over the weekend

Re: [PATCH] gdbstub: Switch to the thread receiving a signal

2021-10-15 Thread Alex Bennée
Pavel Labath writes: > Ping. > > (This is my first qemu patch, so please let me know if I am doing > something wrong.) Apologies it slipped though the cracks. I shall have a look on Monday. > > regards, > pavel > > On 30/09/2021 11:51, Pavel Labath wrote: >> Respond with Txxthread:; inste

Re: [PATCH] gdbstub: Switch to the thread receiving a signal

2021-10-12 Thread Pavel Labath
Ping. (This is my first qemu patch, so please let me know if I am doing something wrong.) regards, pavel On 30/09/2021 11:51, Pavel Labath wrote: Respond with Txxthread:; instead of a plain Sxx to indicate which thread received the signal. Otherwise, the debugger will associate it with t

[PATCH] gdbstub: Switch to the thread receiving a signal

2021-09-30 Thread Pavel Labath
Respond with Txxthread:; instead of a plain Sxx to indicate which thread received the signal. Otherwise, the debugger will associate it with the main one. Also automatically select this thread, as that is what gdb expects. Signed-off-by: Pavel Labath --- gdbstub.c