Re: [PATCH] fuzz: only use generic-fuzz targets on oss-fuzz

2022-06-22 Thread Thomas Huth
On 22/06/2022 18.38, Darren Kenny wrote: On Wednesday, 2022-06-22 at 12:28:40 -04, Alexander Bulekov wrote: On 220622 1703, Darren Kenny wrote: Hi Alex, This looks good to me, so: Reviewed-by: Darren Kenny But, if it is at all possible to use Bash glob in a '[[ ... ]]' test such as: if

Re: [PATCH] fuzz: only use generic-fuzz targets on oss-fuzz

2022-06-22 Thread Darren Kenny
On Wednesday, 2022-06-22 at 12:28:40 -04, Alexander Bulekov wrote: > On 220622 1703, Darren Kenny wrote: >> Hi Alex, >> >> This looks good to me, so: >> >> Reviewed-by: Darren Kenny >> >> But, if it is at all possible to use Bash glob in a '[[ ... ]]' test >> such as: >> >> if [[ $target ==

Re: [PATCH] fuzz: only use generic-fuzz targets on oss-fuzz

2022-06-22 Thread Alexander Bulekov
On 220622 1703, Darren Kenny wrote: > Hi Alex, > > This looks good to me, so: > > Reviewed-by: Darren Kenny > > But, if it is at all possible to use Bash glob in a '[[ ... ]]' test > such as: > > if [[ $target == generic-fuzz-* ]]; then > > that might read better - but it seems the default

Re: [PATCH] fuzz: only use generic-fuzz targets on oss-fuzz

2022-06-22 Thread Darren Kenny
Hi Alex, This looks good to me, so: Reviewed-by: Darren Kenny But, if it is at all possible to use Bash glob in a '[[ ... ]]' test such as: if [[ $target == generic-fuzz-* ]]; then that might read better - but it seems the default is that we don't assume that, or am I wrong? (This is probab

[PATCH] fuzz: only use generic-fuzz targets on oss-fuzz

2022-06-22 Thread Alexander Bulekov
The non-generic-fuzz targets often time-out, or run out of memory. Additionally, they create unreproducible bug-reports. It is possible that this is resulting in failing coverage-reports on OSS-Fuzz. In the future, these test-cases should be fixed, or removed. Signed-off-by: Alexander Bulekov ---