Re: [PATCH] fix vhost_user_blk_watch crash

2020-03-31 Thread Michael S. Tsirkin
On Wed, Mar 25, 2020 at 06:30:08PM -0400, Raphael Norwitz wrote: > On Sun, Mar 29, 2020 at 09:30:24AM -0400, Michael S. Tsirkin wrote: > > > > On Mon, Mar 23, 2020 at 01:29:24PM +0800, Li Feng wrote: > > > the G_IO_HUP is watched in tcp_chr_connect, and the callback > > > vhost_user_blk_watch is n

Re: [PATCH] fix vhost_user_blk_watch crash

2020-03-29 Thread Raphael Norwitz
On Mon, Mar 23, 2020 at 01:29:24PM +0800, Li Feng wrote: > > the G_IO_HUP is watched in tcp_chr_connect, and the callback > vhost_user_blk_watch is not needed, because tcp_chr_hup is registered as > callback. And it will close the tcp link. > > Signed-off-by: Li Feng Reviewed-by: Raphael Norwit

Re: [PATCH] fix vhost_user_blk_watch crash

2020-03-29 Thread Raphael Norwitz
On Sun, Mar 29, 2020 at 09:30:24AM -0400, Michael S. Tsirkin wrote: > > On Mon, Mar 23, 2020 at 01:29:24PM +0800, Li Feng wrote: > > the G_IO_HUP is watched in tcp_chr_connect, and the callback > > vhost_user_blk_watch is not needed, because tcp_chr_hup is registered as > > callback. And it will c

Re: [PATCH] fix vhost_user_blk_watch crash

2020-03-29 Thread Michael S. Tsirkin
On Mon, Mar 23, 2020 at 01:29:24PM +0800, Li Feng wrote: > the G_IO_HUP is watched in tcp_chr_connect, and the callback > vhost_user_blk_watch is not needed, because tcp_chr_hup is registered as > callback. And it will close the tcp link. > > Signed-off-by: Li Feng Raphael would you like to revi

[PATCH] fix vhost_user_blk_watch crash

2020-03-23 Thread Li Feng
the G_IO_HUP is watched in tcp_chr_connect, and the callback vhost_user_blk_watch is not needed, because tcp_chr_hup is registered as callback. And it will close the tcp link. Signed-off-by: Li Feng --- hw/block/vhost-user-blk.c | 19 --- include/hw/virtio/vhost-user-blk