Re: [PATCH] esp: fix migration version check in esp_is_version_5()

2021-06-15 Thread Mark Cave-Ayland
On 14/06/2021 14:47, Philippe Mathieu-Daudé wrote: On 6/14/21 1:59 PM, Mark Cave-Ayland wrote: On 14/06/2021 10:01, Philippe Mathieu-Daudé wrote: On 6/14/21 9:44 AM, Mark Cave-Ayland wrote: On 14/06/2021 06:42, Philippe Mathieu-Daudé wrote: On 6/13/21 12:26 PM, Mark Cave-Ayland wrote: Com

Re: [PATCH] esp: fix migration version check in esp_is_version_5()

2021-06-14 Thread Philippe Mathieu-Daudé
On 6/14/21 1:59 PM, Mark Cave-Ayland wrote: > On 14/06/2021 10:01, Philippe Mathieu-Daudé wrote: > >> On 6/14/21 9:44 AM, Mark Cave-Ayland wrote: >>> On 14/06/2021 06:42, Philippe Mathieu-Daudé wrote: >>> On 6/13/21 12:26 PM, Mark Cave-Ayland wrote: > Commit 4e78f3bf35 "esp: defer command

Re: [PATCH] esp: fix migration version check in esp_is_version_5()

2021-06-14 Thread Mark Cave-Ayland
On 14/06/2021 10:01, Philippe Mathieu-Daudé wrote: On 6/14/21 9:44 AM, Mark Cave-Ayland wrote: On 14/06/2021 06:42, Philippe Mathieu-Daudé wrote: On 6/13/21 12:26 PM, Mark Cave-Ayland wrote: Commit 4e78f3bf35 "esp: defer command completion interrupt on incoming data transfers" added a versio

Re: [PATCH] esp: fix migration version check in esp_is_version_5()

2021-06-14 Thread Philippe Mathieu-Daudé
On 6/14/21 9:44 AM, Mark Cave-Ayland wrote: > On 14/06/2021 06:42, Philippe Mathieu-Daudé wrote: > >> On 6/13/21 12:26 PM, Mark Cave-Ayland wrote: >>> Commit 4e78f3bf35 "esp: defer command completion interrupt on >>> incoming data >>> transfers" added a version check for use with VMSTATE_*_TEST ma

Re: [PATCH] esp: fix migration version check in esp_is_version_5()

2021-06-14 Thread Paolo Bonzini
On 13/06/21 12:26, Mark Cave-Ayland wrote: Commit 4e78f3bf35 "esp: defer command completion interrupt on incoming data transfers" added a version check for use with VMSTATE_*_TEST macros to allow migration from older QEMU versions. Unfortunately the version check fails to work in its current form

Re: [PATCH] esp: fix migration version check in esp_is_version_5()

2021-06-14 Thread Mark Cave-Ayland
On 14/06/2021 06:42, Philippe Mathieu-Daudé wrote: On 6/13/21 12:26 PM, Mark Cave-Ayland wrote: Commit 4e78f3bf35 "esp: defer command completion interrupt on incoming data transfers" added a version check for use with VMSTATE_*_TEST macros to allow migration from older QEMU versions. Unfortunat

Re: [PATCH] esp: fix migration version check in esp_is_version_5()

2021-06-13 Thread Philippe Mathieu-Daudé
On 6/13/21 12:26 PM, Mark Cave-Ayland wrote: > Commit 4e78f3bf35 "esp: defer command completion interrupt on incoming data > transfers" added a version check for use with VMSTATE_*_TEST macros to allow > migration from older QEMU versions. Unfortunately the version check fails to > work in its curr

[PATCH] esp: fix migration version check in esp_is_version_5()

2021-06-13 Thread Mark Cave-Ayland
Commit 4e78f3bf35 "esp: defer command completion interrupt on incoming data transfers" added a version check for use with VMSTATE_*_TEST macros to allow migration from older QEMU versions. Unfortunately the version check fails to work in its current form since if the VMStateDescription version_id i