Re: [PATCH] edk2: get version + date from git submodule

2024-04-09 Thread Michael Tokarev
25.03.2024 17:44, Gerd Hoffmann: Turned out hard-coding version and date in the Makefile wasn't a bright idea. Updating it on edk2 updates is easily forgotten. Fetch the info from git instead. Fixes: https://gitlab.com/qemu-project/qemu/-/issues/2233 Thanks, /mjt

Re: [PATCH] edk2: get version + date from git submodule

2024-04-09 Thread Gerd Hoffmann
On Tue, Apr 09, 2024 at 04:13:34PM +0100, Peter Maydell wrote: > On Tue, 9 Apr 2024 at 15:19, Peter Maydell wrote: > > > > On Tue, 9 Apr 2024 at 15:14, Gerd Hoffmann wrote: > > > > > > Hi, > > > > > > > > + --version-override "$(EDK2_STABLE)-for-qemu" \ > > > > > + -

Re: [PATCH] edk2: get version + date from git submodule

2024-04-09 Thread Peter Maydell
On Tue, 9 Apr 2024 at 15:19, Peter Maydell wrote: > > On Tue, 9 Apr 2024 at 15:14, Gerd Hoffmann wrote: > > > > Hi, > > > > > > + --version-override "$(EDK2_STABLE)-for-qemu" \ > > > > + --release-date "$(EDK2_DATE)" \ > > > > > > Hi -- I've just noticed that we neve

Re: [PATCH] edk2: get version + date from git submodule

2024-04-09 Thread Gerd Hoffmann
Hi, > > + --version-override "$(EDK2_STABLE)-for-qemu" \ > > + --release-date "$(EDK2_DATE)" \ > > Hi -- I've just noticed that we never made this change to > automate the date/version for EDK2 ROMs, but we also never > updated the version by hand. So at the moment w

Re: [PATCH] edk2: get version + date from git submodule

2024-04-09 Thread Peter Maydell
On Tue, 9 Apr 2024 at 15:14, Gerd Hoffmann wrote: > > Hi, > > > > + --version-override "$(EDK2_STABLE)-for-qemu" \ > > > + --release-date "$(EDK2_DATE)" \ > > > > Hi -- I've just noticed that we never made this change to > > automate the date/version for EDK2 ROMs, bu

Re: [PATCH] edk2: get version + date from git submodule

2024-04-09 Thread Peter Maydell
On Mon, 25 Mar 2024 at 14:45, Gerd Hoffmann wrote: > > Turned out hard-coding version and date in the Makefile wasn't a bright > idea. Updating it on edk2 updates is easily forgotten. Fetch the info > from git instead. > > Signed-off-by: Gerd Hoffmann > --- > roms/Makefile | 7 +-- > 1 fil

Re: [PATCH] edk2: get version + date from git submodule

2024-03-26 Thread Gerd Hoffmann
On Mon, Mar 25, 2024 at 02:55:11PM +, Peter Maydell wrote: > On Mon, 25 Mar 2024 at 14:45, Gerd Hoffmann wrote: > > > > Turned out hard-coding version and date in the Makefile wasn't a bright > > idea. Updating it on edk2 updates is easily forgotten. Fetch the info > > from git instead. > >

Re: [PATCH] edk2: get version + date from git submodule

2024-03-25 Thread Peter Maydell
On Mon, 25 Mar 2024 at 14:45, Gerd Hoffmann wrote: > > Turned out hard-coding version and date in the Makefile wasn't a bright > idea. Updating it on edk2 updates is easily forgotten. Fetch the info > from git instead. > > Signed-off-by: Gerd Hoffmann > --- > roms/Makefile | 7 +-- > 1 fil

[PATCH] edk2: get version + date from git submodule

2024-03-25 Thread Gerd Hoffmann
Turned out hard-coding version and date in the Makefile wasn't a bright idea. Updating it on edk2 updates is easily forgotten. Fetch the info from git instead. Signed-off-by: Gerd Hoffmann --- roms/Makefile | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/roms/Makefil