Re: [PATCH] docs/devel: Prohibit calling object_unparent() for memory region

2024-10-12 Thread Akihiko Odaki
On 2024/10/08 22:33, Peter Maydell wrote: On Thu, 29 Aug 2024 at 06:46, Akihiko Odaki wrote: Hi; sorry it's taken me so long to get back to this patch, but I've now re-read some of the discussion in the other threads. I generally agree with your reasoning and think we do need to update the docs

Re: [PATCH] docs/devel: Prohibit calling object_unparent() for memory region

2024-10-08 Thread Peter Maydell
On Thu, 29 Aug 2024 at 06:46, Akihiko Odaki wrote: Hi; sorry it's taken me so long to get back to this patch, but I've now re-read some of the discussion in the other threads. I generally agree with your reasoning and think we do need to update the docs here. I think we could be more specific in

Re: [PATCH] docs/devel: Prohibit calling object_unparent() for memory region

2024-09-10 Thread Peter Maydell
On Tue, 10 Sept 2024 at 18:27, Michael S. Tsirkin wrote: > > On Thu, Aug 29, 2024 at 02:46:48PM +0900, Akihiko Odaki wrote: > > Previously it was allowed to call object_unparent() for a memory region > > in instance_finalize() of its parent. However, such a call typically > > has no effect because

Re: [PATCH] docs/devel: Prohibit calling object_unparent() for memory region

2024-09-10 Thread Michael S. Tsirkin
On Thu, Aug 29, 2024 at 02:46:48PM +0900, Akihiko Odaki wrote: > Previously it was allowed to call object_unparent() for a memory region > in instance_finalize() of its parent. However, such a call typically > has no effect because child objects get unparented before > instance_finalize(). > > Wor

[PATCH] docs/devel: Prohibit calling object_unparent() for memory region

2024-08-28 Thread Akihiko Odaki
Previously it was allowed to call object_unparent() for a memory region in instance_finalize() of its parent. However, such a call typically has no effect because child objects get unparented before instance_finalize(). Worse, memory regions typically gets finalized when they get unparented before