Re: [PATCH] display: include dependencies explicitly

2022-11-09 Thread Laurent Vivier
On 11/9/22 23:21, Michael S. Tsirkin wrote: acpi-vga-stub.c pulls in vga_int.h However that currently pulls in ui/console.h which breaks e.g. on systems without pixman. It's better to remove ui/console.h from vga_int.h and directly include it where it's used. Signed-off-by: Michael S. Tsirkin

Re: [PATCH] display: include dependencies explicitly

2022-11-09 Thread Philippe Mathieu-Daudé
On 9/11/22 23:21, Michael S. Tsirkin wrote: acpi-vga-stub.c pulls in vga_int.h However that currently pulls in ui/console.h which breaks e.g. on systems without pixman. It's better to remove ui/console.h from vga_int.h and directly include it where it's used. Reported-by: Miroslav Rezanina Re

[PATCH] display: include dependencies explicitly

2022-11-09 Thread Michael S. Tsirkin
acpi-vga-stub.c pulls in vga_int.h However that currently pulls in ui/console.h which breaks e.g. on systems without pixman. It's better to remove ui/console.h from vga_int.h and directly include it where it's used. Signed-off-by: Michael S. Tsirkin --- hw/display/vga_int.h| 1 - include