Re: [PATCH] disas/sh4: Add missing fallthrough annotations

2020-07-09 Thread Richard Henderson
On 6/29/20 10:59 PM, Thomas Huth wrote: > Add fallthrough annotations to be able to compile the code without > warnings with -Wimplicit-fallthrough. Looking at the code, it seems > like the fallthrough is indeed intended here, so the comments should > be appropriate. > > Signed-off-by: Thomas Huth

Re: [PATCH] disas/sh4: Add missing fallthrough annotations

2020-06-29 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200630055953.9309-1-th...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] disas/sh4: Add missing fallthrough annotations Type: series Message-id: 20200630055953.9309-1-th

[PATCH] disas/sh4: Add missing fallthrough annotations

2020-06-29 Thread Thomas Huth
Add fallthrough annotations to be able to compile the code without warnings with -Wimplicit-fallthrough. Looking at the code, it seems like the fallthrough is indeed intended here, so the comments should be appropriate. Signed-off-by: Thomas Huth --- Note: The new lines use TABs since all the su