Re: [PATCH] decodetree: Allow 'dot' in opcode names

2021-01-12 Thread Philippe Mathieu-Daudé
On 1/12/21 11:28 PM, Eduardo Habkost wrote: > On Tue, Jan 12, 2021 at 11:15:38PM +0100, Philippe Mathieu-Daudé wrote: >> On 1/12/21 9:44 PM, Richard Henderson wrote: >>> On 1/12/21 8:41 AM, Philippe Mathieu-Daudé wrote: Some ISA use a dot in their opcodes. Allow the decodetree script to p

Re: [PATCH] decodetree: Allow 'dot' in opcode names

2021-01-12 Thread Eduardo Habkost
On Tue, Jan 12, 2021 at 11:19:49PM +0100, Philippe Mathieu-Daudé wrote: > On 1/12/21 10:05 PM, Eduardo Habkost wrote: [...] > >> diff --git a/scripts/decodetree.py b/scripts/decodetree.py > >> index 47aa9caf6d1..b7572589e64 100644 > >> --- a/scripts/decodetree.py > >> +++ b/scripts/decodetree.py >

Re: [PATCH] decodetree: Allow 'dot' in opcode names

2021-01-12 Thread Eduardo Habkost
On Tue, Jan 12, 2021 at 11:15:38PM +0100, Philippe Mathieu-Daudé wrote: > On 1/12/21 9:44 PM, Richard Henderson wrote: > > On 1/12/21 8:41 AM, Philippe Mathieu-Daudé wrote: > >> Some ISA use a dot in their opcodes. Allow the decodetree > >> script to process them. The dot is replaced by an undersco

Re: [PATCH] decodetree: Allow 'dot' in opcode names

2021-01-12 Thread Philippe Mathieu-Daudé
On 1/12/21 10:05 PM, Eduardo Habkost wrote: > On Tue, Jan 12, 2021 at 07:41:56PM +0100, Philippe Mathieu-Daudé wrote: >> Some ISA use a dot in their opcodes. Allow the decodetree >> script to process them. The dot is replaced by an underscore >> in the generated code. > > Will something break if w

Re: [PATCH] decodetree: Allow 'dot' in opcode names

2021-01-12 Thread Philippe Mathieu-Daudé
On 1/12/21 9:44 PM, Richard Henderson wrote: > On 1/12/21 8:41 AM, Philippe Mathieu-Daudé wrote: >> Some ISA use a dot in their opcodes. Allow the decodetree >> script to process them. The dot is replaced by an underscore >> in the generated code. > > Given that you then have to remember to use '_

Re: [PATCH] decodetree: Allow 'dot' in opcode names

2021-01-12 Thread Eduardo Habkost
On Tue, Jan 12, 2021 at 07:41:56PM +0100, Philippe Mathieu-Daudé wrote: > Some ISA use a dot in their opcodes. Allow the decodetree > script to process them. The dot is replaced by an underscore > in the generated code. Will something break if we just use underscores instead of dots in the input f

Re: [PATCH] decodetree: Allow 'dot' in opcode names

2021-01-12 Thread Richard Henderson
On 1/12/21 8:41 AM, Philippe Mathieu-Daudé wrote: > Some ISA use a dot in their opcodes. Allow the decodetree > script to process them. The dot is replaced by an underscore > in the generated code. Given that you then have to remember to use '_' on the C side, what advantage does this give? r~

[PATCH] decodetree: Allow 'dot' in opcode names

2021-01-12 Thread Philippe Mathieu-Daudé
Some ISA use a dot in their opcodes. Allow the decodetree script to process them. The dot is replaced by an underscore in the generated code. Signed-off-by: Philippe Mathieu-Daudé --- scripts/decodetree.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/decodetree.p