Re: [PATCH] coroutine-ucontext: Save fake stack for pooled coroutine

2024-01-16 Thread Akihiko Odaki
On 2024/01/16 17:42, Marc-André Lureau wrote: Hi On Mon, Jan 15, 2024 at 10:49 PM Stefan Hajnoczi wrote: On Fri, Jan 12, 2024 at 07:36:19PM +0900, Akihiko Odaki wrote: Coroutine may be pooled even after COROUTINE_TERMINATE if CONFIG_COROUTINE_POOL is enabled and fake stack should be saved in

Re: [PATCH] coroutine-ucontext: Save fake stack for pooled coroutine

2024-01-16 Thread Marc-André Lureau
Hi On Mon, Jan 15, 2024 at 10:49 PM Stefan Hajnoczi wrote: > > On Fri, Jan 12, 2024 at 07:36:19PM +0900, Akihiko Odaki wrote: > > Coroutine may be pooled even after COROUTINE_TERMINATE if > > CONFIG_COROUTINE_POOL is enabled and fake stack should be saved in > > such a case to keep AddressSanitiz

Re: [PATCH] coroutine-ucontext: Save fake stack for pooled coroutine

2024-01-15 Thread Stefan Hajnoczi
On Fri, Jan 12, 2024 at 07:36:19PM +0900, Akihiko Odaki wrote: > Coroutine may be pooled even after COROUTINE_TERMINATE if > CONFIG_COROUTINE_POOL is enabled and fake stack should be saved in > such a case to keep AddressSanitizerUseAfterReturn working. Even worse, > I'm seeing stack corruption wit

[PATCH] coroutine-ucontext: Save fake stack for pooled coroutine

2024-01-12 Thread Akihiko Odaki
Coroutine may be pooled even after COROUTINE_TERMINATE if CONFIG_COROUTINE_POOL is enabled and fake stack should be saved in such a case to keep AddressSanitizerUseAfterReturn working. Even worse, I'm seeing stack corruption without fake stack being saved. Signed-off-by: Akihiko Odaki --- util/c