Re: [PATCH] coroutine: cap per-thread local pool size

2024-03-21 Thread Stefan Hajnoczi
On Thu, 21 Mar 2024 at 08:22, Kevin Wolf wrote: > > Am 20.03.2024 um 15:09 hat Daniel P. Berrangé geschrieben: > > On Wed, Mar 20, 2024 at 09:35:39AM -0400, Stefan Hajnoczi wrote: > > > On Tue, Mar 19, 2024 at 08:10:49PM +, Daniel P. Berrangé wrote: > > > > On Tue, Mar 19, 2024 at 01:55:10PM -

Re: [PATCH] coroutine: cap per-thread local pool size

2024-03-21 Thread Kevin Wolf
Am 20.03.2024 um 15:09 hat Daniel P. Berrangé geschrieben: > On Wed, Mar 20, 2024 at 09:35:39AM -0400, Stefan Hajnoczi wrote: > > On Tue, Mar 19, 2024 at 08:10:49PM +, Daniel P. Berrangé wrote: > > > On Tue, Mar 19, 2024 at 01:55:10PM -0400, Stefan Hajnoczi wrote: > > > > On Tue, Mar 19, 2024 a

Re: [PATCH] coroutine: cap per-thread local pool size

2024-03-20 Thread Daniel P . Berrangé
On Wed, Mar 20, 2024 at 09:35:39AM -0400, Stefan Hajnoczi wrote: > On Tue, Mar 19, 2024 at 08:10:49PM +, Daniel P. Berrangé wrote: > > On Tue, Mar 19, 2024 at 01:55:10PM -0400, Stefan Hajnoczi wrote: > > > On Tue, Mar 19, 2024 at 01:43:32PM +, Daniel P. Berrangé wrote: > > > > On Mon, Mar 1

Re: [PATCH] coroutine: cap per-thread local pool size

2024-03-20 Thread Stefan Hajnoczi
On Tue, Mar 19, 2024 at 08:10:49PM +, Daniel P. Berrangé wrote: > On Tue, Mar 19, 2024 at 01:55:10PM -0400, Stefan Hajnoczi wrote: > > On Tue, Mar 19, 2024 at 01:43:32PM +, Daniel P. Berrangé wrote: > > > On Mon, Mar 18, 2024 at 02:34:29PM -0400, Stefan Hajnoczi wrote: > > > > diff --git a/

Re: [PATCH] coroutine: cap per-thread local pool size

2024-03-19 Thread Daniel P . Berrangé
On Tue, Mar 19, 2024 at 06:41:28PM +0100, Kevin Wolf wrote: > Am 19.03.2024 um 18:10 hat Daniel P. Berrangé geschrieben: > > On Tue, Mar 19, 2024 at 05:54:38PM +0100, Kevin Wolf wrote: > > > Am 19.03.2024 um 14:43 hat Daniel P. Berrangé geschrieben: > > > > On Mon, Mar 18, 2024 at 02:34:29PM -0400,

Re: [PATCH] coroutine: cap per-thread local pool size

2024-03-19 Thread Daniel P . Berrangé
On Tue, Mar 19, 2024 at 01:55:10PM -0400, Stefan Hajnoczi wrote: > On Tue, Mar 19, 2024 at 01:43:32PM +, Daniel P. Berrangé wrote: > > On Mon, Mar 18, 2024 at 02:34:29PM -0400, Stefan Hajnoczi wrote: > > > diff --git a/util/qemu-coroutine.c b/util/qemu-coroutine.c > > > index 5fd2dbaf8b..279095

Re: [PATCH] coroutine: cap per-thread local pool size

2024-03-19 Thread Stefan Hajnoczi
On Tue, Mar 19, 2024 at 01:43:32PM +, Daniel P. Berrangé wrote: > On Mon, Mar 18, 2024 at 02:34:29PM -0400, Stefan Hajnoczi wrote: > > The coroutine pool implementation can hit the Linux vm.max_map_count > > limit, causing QEMU to abort with "failed to allocate memory for stack" > > or "failed

Re: [PATCH] coroutine: cap per-thread local pool size

2024-03-19 Thread Kevin Wolf
Am 19.03.2024 um 18:10 hat Daniel P. Berrangé geschrieben: > On Tue, Mar 19, 2024 at 05:54:38PM +0100, Kevin Wolf wrote: > > Am 19.03.2024 um 14:43 hat Daniel P. Berrangé geschrieben: > > > On Mon, Mar 18, 2024 at 02:34:29PM -0400, Stefan Hajnoczi wrote: > > > > The coroutine pool implementation ca

Re: [PATCH] coroutine: cap per-thread local pool size

2024-03-19 Thread Daniel P . Berrangé
On Tue, Mar 19, 2024 at 05:54:38PM +0100, Kevin Wolf wrote: > Am 19.03.2024 um 14:43 hat Daniel P. Berrangé geschrieben: > > On Mon, Mar 18, 2024 at 02:34:29PM -0400, Stefan Hajnoczi wrote: > > > The coroutine pool implementation can hit the Linux vm.max_map_count > > > limit, causing QEMU to abort

Re: [PATCH] coroutine: cap per-thread local pool size

2024-03-19 Thread Kevin Wolf
Am 19.03.2024 um 14:43 hat Daniel P. Berrangé geschrieben: > On Mon, Mar 18, 2024 at 02:34:29PM -0400, Stefan Hajnoczi wrote: > > The coroutine pool implementation can hit the Linux vm.max_map_count > > limit, causing QEMU to abort with "failed to allocate memory for stack" > > or "failed to set up

Re: [PATCH] coroutine: cap per-thread local pool size

2024-03-19 Thread Sanjay Rao
On Tue, Mar 19, 2024 at 9:32 AM Kevin Wolf wrote: > Am 18.03.2024 um 19:34 hat Stefan Hajnoczi geschrieben: > > The coroutine pool implementation can hit the Linux vm.max_map_count > > limit, causing QEMU to abort with "failed to allocate memory for stack" > > or "failed to set up stack guard pag

Re: [PATCH] coroutine: cap per-thread local pool size

2024-03-19 Thread Stefan Hajnoczi
On Tue, Mar 19, 2024 at 02:32:06PM +0100, Kevin Wolf wrote: > Am 18.03.2024 um 19:34 hat Stefan Hajnoczi geschrieben: > > The coroutine pool implementation can hit the Linux vm.max_map_count > > limit, causing QEMU to abort with "failed to allocate memory for stack" > > or "failed to set up stack g

Re: [PATCH] coroutine: cap per-thread local pool size

2024-03-19 Thread Daniel P . Berrangé
On Mon, Mar 18, 2024 at 02:34:29PM -0400, Stefan Hajnoczi wrote: > The coroutine pool implementation can hit the Linux vm.max_map_count > limit, causing QEMU to abort with "failed to allocate memory for stack" > or "failed to set up stack guard page" during coroutine creation. > > This happens bec

Re: [PATCH] coroutine: cap per-thread local pool size

2024-03-19 Thread Kevin Wolf
Am 18.03.2024 um 19:34 hat Stefan Hajnoczi geschrieben: > The coroutine pool implementation can hit the Linux vm.max_map_count > limit, causing QEMU to abort with "failed to allocate memory for stack" > or "failed to set up stack guard page" during coroutine creation. > > This happens because per-

[PATCH] coroutine: cap per-thread local pool size

2024-03-18 Thread Stefan Hajnoczi
The coroutine pool implementation can hit the Linux vm.max_map_count limit, causing QEMU to abort with "failed to allocate memory for stack" or "failed to set up stack guard page" during coroutine creation. This happens because per-thread pools can grow to tens of thousands of coroutines. Each cor