Peter Maydell writes:
> On Wed, 27 Jul 2022 at 18:28, Raphael Norwitz
> wrote:
>>
>> On Tue, Jul 26, 2022 at 03:57:42PM +0100, Peter Maydell wrote:
>> > On Fri, 1 Jul 2022 at 06:41, Markus Armbruster wrote:
>> > > Could we use a contrib/README with an explanation what "contrib" means,
>> > >
Le 30/06/2022 à 10:52, Markus Armbruster a écrit :
We allocate VuVirtqElement with g_malloc() in
virtqueue_alloc_element(), but free it with free() in
vhost-user-blk.c. Harmless, but use g_free() anyway.
One of the calls is guarded by a "not null" condition. Useless,
because it cannot be null
On Wed, 27 Jul 2022 at 18:28, Raphael Norwitz
wrote:
>
> On Tue, Jul 26, 2022 at 03:57:42PM +0100, Peter Maydell wrote:
> > On Fri, 1 Jul 2022 at 06:41, Markus Armbruster wrote:
> > > Could we use a contrib/README with an explanation what "contrib" means,
> > > and how to build and use the stuff
On Tue, Jul 26, 2022 at 03:57:42PM +0100, Peter Maydell wrote:
> On Fri, 1 Jul 2022 at 06:41, Markus Armbruster wrote:
> > Could we use a contrib/README with an explanation what "contrib" means,
> > and how to build and use the stuff there?
>
> I would rather we got rid of contrib/ entirely. Our
On Fri, 1 Jul 2022 at 06:41, Markus Armbruster wrote:
> Could we use a contrib/README with an explanation what "contrib" means,
> and how to build and use the stuff there?
I would rather we got rid of contrib/ entirely. Our git repo
should contain things we care about enough to really support
and
On Thu, Jun 30, 2022 at 10:52:19AM +0200, Markus Armbruster wrote:
> We allocate VuVirtqElement with g_malloc() in
> virtqueue_alloc_element(), but free it with free() in
> vhost-user-blk.c. Harmless, but use g_free() anyway.
>
> One of the calls is guarded by a "not null" condition. Useless,
>
Could this go via qemu-trivial now?
Markus Armbruster writes:
> We allocate VuVirtqElement with g_malloc() in
> virtqueue_alloc_element(), but free it with free() in
> vhost-user-blk.c. Harmless, but use g_free() anyway.
>
> One of the calls is guarded by a "not null" condition. Useless,
> bec
Raphael Norwitz writes:
> On Thu, Jun 30, 2022 at 10:52:19AM +0200, Markus Armbruster wrote:
>> We allocate VuVirtqElement with g_malloc() in
>> virtqueue_alloc_element(), but free it with free() in
>> vhost-user-blk.c. Harmless, but use g_free() anyway.
>>
>> One of the calls is guarded by a "
On Thu, Jun 30, 2022 at 10:52:19AM +0200, Markus Armbruster wrote:
> We allocate VuVirtqElement with g_malloc() in
> virtqueue_alloc_element(), but free it with free() in
> vhost-user-blk.c. Harmless, but use g_free() anyway.
>
> One of the calls is guarded by a "not null" condition. Useless,
>
We allocate VuVirtqElement with g_malloc() in
virtqueue_alloc_element(), but free it with free() in
vhost-user-blk.c. Harmless, but use g_free() anyway.
One of the calls is guarded by a "not null" condition. Useless,
because it cannot be null (it's dereferenced right before), and even
it it coul
10 matches
Mail list logo
